public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: "Bartłomiej Konecki" <bartekkonecki97@gmail.com>
Cc: Vaibhav Agarwal <vaibhav.sr@gmail.com>,
	Mark Greer <mgreer@animalcreek.com>,
	Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: document codec mutex usage
Date: Thu, 19 Feb 2026 17:31:56 +0300	[thread overview]
Message-ID: <aZce3JIfKM_FgzyC@stanley.mountain> (raw)
In-Reply-To: <aZcP88KGUnxDBjTT@LT495s>

On Thu, Feb 19, 2026 at 02:28:19PM +0100, Bartłomiej Konecki wrote:
> Add comments describing lock and register_mutex
> in struct gbaudio_codec_info.
> The lock protects the codec runtime state and module/DAI lists, while
> register_mutex protects hardware registers.
> Improve readability and clarify locking semantics.
> 
> Signed-off-by: Bartłomiej Konecki <bartekkonecki97@gmail.com>
> ---
>  drivers/staging/greybus/audio_codec.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h
> index f3f7a7ec6be4..90dd3426d4a4 100644
> --- a/drivers/staging/greybus/audio_codec.h
> +++ b/drivers/staging/greybus/audio_codec.h
> @@ -70,8 +70,9 @@ struct gbaudio_codec_info {
>  	struct list_head module_list;
>  	/* to maintain runtime stream params for each DAI */
>  	struct list_head dai_list;
> -	struct mutex lock;
> +	struct mutex lock;	/* protects codec state and module/DAI lists */
>  	struct mutex register_mutex;
> +	/* serializes access to codec hardware registers*/

No, it doesn't.

regards,
dan carpenter


      reply	other threads:[~2026-02-19 14:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-19 13:28 [PATCH] staging: greybus: document codec mutex usage Bartłomiej Konecki
2026-02-19 14:31 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aZce3JIfKM_FgzyC@stanley.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=bartekkonecki97@gmail.com \
    --cc=elder@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mgreer@animalcreek.com \
    --cc=vaibhav.sr@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox