[PATCH v1 0/2] staging: greybus: audio: small fixes

[PATCH v1 0/2] staging: greybus: audio: small fixes

[Hardik Phalet]

[-- Attachment #1: Type: text/plain, Size: 299 bytes --]

This series contains two small fixes for the Greybus audio manager:

1) Fix a NULL dereference in gb_audio_manager_get_module().
2) Drop a stale TODO in the module release callback.

Both are correctness / cleanup fixes with no functional change beyond
preventing crashes.

Thanks,
Hardik

[-- Attachment #2: 0000-cover-letter.patch --]
[-- Type: text/x-patch, Size: 556 bytes --]

From b381767672023234e6d18482a7b68aeb78fdf2b9 Mon Sep 17 00:00:00 2001
From: Hardik Phalet <hardik.phalet@pm.me>
Date: Fri, 20 Feb 2026 11:00:41 +0530
Subject: [PATCH v1 0/2] *** SUBJECT HERE ***

*** BLURB HERE ***

Hardik Phalet (2):
  staging: greybus: audio: fix NULL dereference in
    gb_audio_manager_get_module()
  staging: greybus: audio: drop stale TODO in module release

 drivers/staging/greybus/audio_manager.c        | 3 ++-
 drivers/staging/greybus/audio_manager_module.c | 1 -
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.53.0

[PATCH v1 1/2] staging: greybus: audio: fix NULL dereference in gb_audio_manager_get_module()

[Hardik Phalet]

[-- Attachment #1: Type: text/plain, Size: 13 bytes --]

Empty Message

[-- Attachment #2: 0001-staging-greybus-audio-fix-NULL-dereference-in.patch --]
[-- Type: text/x-patch, Size: 1229 bytes --]

From 3b496a0daa8cbbbe50a7a09e6daf7bb4d8e6e9e5 Mon Sep 17 00:00:00 2001
From: Hardik Phalet <hardik.phalet@pm.me>
Date: Fri, 20 Feb 2026 10:41:49 +0530
Subject: [PATCH v1 1/2] staging: greybus: audio: fix NULL dereference in
 gb_audio_manager_get_module()

gb_audio_manager_get_module() calls gb_audio_manager_get_locked(), which
can return NULL when the requested id does not exist. The returned
pointer is dereferenced unconditionally via kobject_get(), leading to a
NULL pointer dereference.

Only take a kobject reference when the module is found.

Signed-off-by: Hardik Phalet <hardik.phalet@pm.me>
---
 drivers/staging/greybus/audio_manager.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c
index 27ca5f796c5f..1da8804e61ca 100644
--- a/drivers/staging/greybus/audio_manager.c
+++ b/drivers/staging/greybus/audio_manager.c
@@ -111,7 +111,8 @@ struct gb_audio_manager_module *gb_audio_manager_get_module(int id)
 
 	down_read(&modules_rwsem);
 	module = gb_audio_manager_get_locked(id);
-	kobject_get(&module->kobj);
+	if (module)
+		kobject_get(&module->kobj);
 	up_read(&modules_rwsem);
 	return module;
 }
-- 
2.53.0

Re: [PATCH v1 1/2] staging: greybus: audio: fix NULL dereference in gb_audio_manager_get_module()

[Greg KH]

On Fri, Feb 20, 2026 at 05:44:19AM +0000, Hardik Phalet wrote:
> Empty Message

Something went wrong, please resend these as a v2.

thanks,

greg k-h

Re: [PATCH v1 1/2] staging: greybus: audio: fix NULL dereference in gb_audio_manager_get_module()

[Dan Carpenter]

On Fri, Feb 20, 2026 at 05:44:19AM +0000, Hardik Phalet wrote:
> Empty Message

> From 3b496a0daa8cbbbe50a7a09e6daf7bb4d8e6e9e5 Mon Sep 17 00:00:00 2001
> From: Hardik Phalet <hardik.phalet@pm.me>
> Date: Fri, 20 Feb 2026 10:41:49 +0530
> Subject: [PATCH v1 1/2] staging: greybus: audio: fix NULL dereference in
>  gb_audio_manager_get_module()
> 
> gb_audio_manager_get_module() calls gb_audio_manager_get_locked(), which
> can return NULL when the requested id does not exist. The returned
> pointer is dereferenced unconditionally via kobject_get(), leading to a
> NULL pointer dereference.
> 
> Only take a kobject reference when the module is found.
> 
> Signed-off-by: Hardik Phalet <hardik.phalet@pm.me>
> ---
>  drivers/staging/greybus/audio_manager.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c
> index 27ca5f796c5f..1da8804e61ca 100644
> --- a/drivers/staging/greybus/audio_manager.c
> +++ b/drivers/staging/greybus/audio_manager.c
> @@ -111,7 +111,8 @@ struct gb_audio_manager_module *gb_audio_manager_get_module(int id)

I don't think the gb_audio_manager_get_module() function is ever called.

Otherwise probably this would need a Fixes tag.

regards,
dan carpenter

[PATCH v1 2/2] staging: greybus: audio: drop stale TODO in module release

[Hardik Phalet]

[-- Attachment #1: Type: text/plain, Size: 13 bytes --]

Empty Message

[-- Attachment #2: 0002-staging-greybus-audio-drop-stale-TODO-in-module-rele.patch --]
[-- Type: text/x-patch, Size: 1117 bytes --]

From b381767672023234e6d18482a7b68aeb78fdf2b9 Mon Sep 17 00:00:00 2001
From: Hardik Phalet <hardik.phalet@pm.me>
Date: Fri, 20 Feb 2026 10:46:50 +0530
Subject: [PATCH v1 2/2] staging: greybus: audio: drop stale TODO in module
 release

Modules are removed from modules_list in gb_audio_manager_remove() and
gb_audio_manager_remove_all() before kobject_put(). The TODO suggesting
list deletion in the kobject release callback is stale and misleading.

Signed-off-by: Hardik Phalet <hardik.phalet@pm.me>
---
 drivers/staging/greybus/audio_manager_module.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c
index 4a4dfb42f50f..b1dd3da9f57c 100644
--- a/drivers/staging/greybus/audio_manager_module.c
+++ b/drivers/staging/greybus/audio_manager_module.c
@@ -69,7 +69,6 @@ static void gb_audio_module_release(struct kobject *kobj)
 	struct gb_audio_manager_module *module = to_gb_audio_module(kobj);
 
 	pr_info("Destroying audio module #%d\n", module->id);
-	/* TODO -> delete from list */
 	kfree(module);
 }
 
-- 
2.53.0

Re: [PATCH v1 0/2] staging: greybus: audio: small fixes

[Hardik Phalet]

Apologies, resending via git email for proper formatting.

Re: [PATCH v1 0/2] staging: greybus: audio: small fixes

[Greg KH]

On Fri, Feb 20, 2026 at 05:41:50AM +0000, Hardik Phalet wrote:
> This series contains two small fixes for the Greybus audio manager:
> 
> 1) Fix a NULL dereference in gb_audio_manager_get_module().
> 2) Drop a stale TODO in the module release callback.
> 
> Both are correctness / cleanup fixes with no functional change beyond
> preventing crashes.
> 
> Thanks,
> Hardik

> From b381767672023234e6d18482a7b68aeb78fdf2b9 Mon Sep 17 00:00:00 2001
> From: Hardik Phalet <hardik.phalet@pm.me>
> Date: Fri, 20 Feb 2026 11:00:41 +0530
> Subject: [PATCH v1 0/2] *** SUBJECT HERE ***
> 
> *** BLURB HERE ***


No blurb?