[PATCH] staging:iio:impedance-analyzer rename camel case text

[PATCH] staging:iio:impedance-analyzer rename camel case text

[Harpreet Saini]

Rename camel case text. This was reported by checkpatch.pl

Signed-off-by: Harpreet Saini <sainiharpreet29@yahoo.com>
---
 drivers/staging/iio/impedance-analyzer/ad5933.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
index 85a4223295cd..f38d94613ea1 100644
--- a/drivers/staging/iio/impedance-analyzer/ad5933.c
+++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
@@ -43,10 +43,10 @@
 #define AD5933_CTRL_POWER_DOWN		(0xA << 4)
 #define AD5933_CTRL_STANDBY		(0xB << 4)
 
-#define AD5933_CTRL_RANGE_2000mVpp	(0x0 << 1)
-#define AD5933_CTRL_RANGE_200mVpp	(0x1 << 1)
-#define AD5933_CTRL_RANGE_400mVpp	(0x2 << 1)
-#define AD5933_CTRL_RANGE_1000mVpp	(0x3 << 1)
+#define AD5933_CTRL_RANGE_2000_M_VPP	(0x0 << 1)
+#define AD5933_CTRL_RANGE_200_M_VPP	(0x1 << 1)
+#define AD5933_CTRL_RANGE_400_M_VPP	(0x2 << 1)
+#define AD5933_CTRL_RANGE_1000_M_VPP	(0x3 << 1)
 #define AD5933_CTRL_RANGE(x)		((x) << 1)
 
 #define AD5933_CTRL_PGA_GAIN_1		(0x1 << 0)
@@ -68,8 +68,8 @@
 #define AD5933_I2C_ADDR_POINTER		0xB0
 
 /* Device Specs */
-#define AD5933_INT_OSC_FREQ_Hz		16776000
-#define AD5933_MAX_OUTPUT_FREQ_Hz	100000
+#define AD5933_INT_OSC_FREQ_HZ		16776000
+#define AD5933_MAX_OUTPUT_FREQ_HZ	100000
 #define AD5933_MAX_RETRIES		100
 
 #define AD5933_OUT_RANGE		1
@@ -303,7 +303,7 @@ static ssize_t ad5933_store_frequency(struct device *dev,
 	if (ret)
 		return ret;
 
-	if (val > AD5933_MAX_OUTPUT_FREQ_Hz)
+	if (val > AD5933_MAX_OUTPUT_FREQ_HZ)
 		return -EINVAL;
 
 	if (!iio_device_claim_direct(indio_dev))
@@ -699,7 +699,7 @@ static int ad5933_probe(struct i2c_client *client)
 		st->mclk_hz = ext_clk_hz;
 		st->ctrl_lb = AD5933_CTRL_EXT_SYSCLK;
 	} else {
-		st->mclk_hz = AD5933_INT_OSC_FREQ_Hz;
+		st->mclk_hz = AD5933_INT_OSC_FREQ_HZ;
 		st->ctrl_lb = AD5933_CTRL_INT_SYSCLK;
 	}
 
-- 
2.43.0

Re: [PATCH] staging:iio:impedance-analyzer rename camel case text

[Dan Carpenter]

On Sat, Feb 21, 2026 at 04:14:24AM -0500, Harpreet Saini wrote:
> Rename camel case text. This was reported by checkpatch.pl
> 
> Signed-off-by: Harpreet Saini <sainiharpreet29@yahoo.com>

MV are a billion mV.  milli vs mega.  The original is correct.

regards,
dan carpenter

Re: [PATCH] staging:iio:impedance-analyzer rename camel case text

[Andy Shevchenko]

On Sat, Feb 21, 2026 at 04:14:24AM -0500, Harpreet Saini wrote:
> Rename camel case text. This was reported by checkpatch.pl

CamelCase
:-)

Missed period.

...

> -#define AD5933_CTRL_RANGE_2000mVpp	(0x0 << 1)
> -#define AD5933_CTRL_RANGE_200mVpp	(0x1 << 1)
> -#define AD5933_CTRL_RANGE_400mVpp	(0x2 << 1)
> -#define AD5933_CTRL_RANGE_1000mVpp	(0x3 << 1)
> +#define AD5933_CTRL_RANGE_2000_M_VPP	(0x0 << 1)
> +#define AD5933_CTRL_RANGE_200_M_VPP	(0x1 << 1)
> +#define AD5933_CTRL_RANGE_400_M_VPP	(0x2 << 1)
> +#define AD5933_CTRL_RANGE_1000_M_VPP	(0x3 << 1)

No, these all are pretty much fine, they are for physical units.

...

> -#define AD5933_INT_OSC_FREQ_Hz		16776000
> -#define AD5933_MAX_OUTPUT_FREQ_Hz	100000
> +#define AD5933_INT_OSC_FREQ_HZ		16776000
> +#define AD5933_MAX_OUTPUT_FREQ_HZ	100000

These are okay, as it's historical suffix for Hz in capital letters.

-- 
With Best Regards,
Andy Shevchenko