From: Dan Carpenter <dan.carpenter@linaro.org>
To: Priit Laes <plaes@plaes.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Minu Jin" <s9430939@naver.com>,
"Archit Anant" <architanant5@gmail.com>,
"Andy Shevchenko" <andriy.shevchenko@intel.com>,
"Yuvraj Singh Chauhan" <ysinghcin@gmail.com>,
"JJ Strnad" <strnad.jj@gmail.com>,
"Julia Lawall" <julia.lawall@inria.fr>,
"Ethan Tidmore" <ethantidmore06@gmail.com>,
"Navaneeth K" <knavaneeth786@gmail.com>,
"Artur Stupa" <arthur.stupa@gmail.com>,
"William Hansen-Baird" <william.hansen.baird@gmail.com>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Tanjim Kamal" <tanjimkamal1@gmail.com>,
"Abraham Samuel Adekunle" <abrahamadekunle50@gmail.com>,
"Michael Straube" <straube.linux@gmail.com>,
"Hans de Goede" <hansg@kernel.org>,
"Vivek BalachandharTN" <vivek.balachandhar@gmail.com>,
"Zhuoheng Li" <lizhuoheng@kylinos.cn>,
"Michael Huang" <tehsiu.huang@gmail.com>,
"Nino Zhang" <ninozhang001@gmail.com>,
"Thomas Gleixner" <tglx@kernel.org>,
"Rogério Fernandes Pereira" <rfp2005@gmail.com>,
"Ingo Molnar" <mingo@kernel.org>,
"Diksha Kumari" <dikshakdevgan@gmail.com>,
"Karthikey D Kadati" <karthikey3608@gmail.com>,
"Khushal Chitturi" <khushalchitturi@gmail.com>,
"SeungJu Cheon" <suunj1331@gmail.com>,
"Akiyoshi Kurita" <weibu@redadmin.org>,
"Erick Karanja" <karanja99erick@gmail.com>,
"Sun Jian" <sun.jian.kdev@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 11/11] staging: rtl8723bs: rtw_ieee80211: Reduce global symbols
Date: Mon, 23 Feb 2026 10:32:31 +0300 [thread overview]
Message-ID: <aZwCj4WEeS_B3FzF@stanley.mountain> (raw)
In-Reply-To: <20260221190628.50273-12-plaes@plaes.org>
On Sat, Feb 21, 2026 at 09:01:41PM +0200, Priit Laes wrote:
> Mark internally used symbols/functions as static and drop some unused
> ones.
> WPA_CIPHER_SUITE_WRAP/RSN_CIPHER_SUITE_WRAP are left as commented, as
> these might be actually useful for understanding the code.
>
> Changes since v1:
> * Comment out unused variables WPA_CIPHER_SUITE_WRAP/RSN_CIPHER_SUITE_WRAP
Put this under the --- cut off line
>
> Signed-off-by: Priit Laes <plaes@plaes.org>
> ---
^^^
Here.
But really we're not going to allow commented out code. Just delete
it. There are reasons why people would merge dead code, such as for
example, in some cases code needs legal approval and it's easier to get
everything approved at once even when it's not needed immediately. But
here we're not going to allow it.
This would be easier to review as separate patches:
[patch 1] Delete dead code.
[patch 2] make functions static
[patch 3] move the arrays and make them static const
regards,
dan carpenter
prev parent reply other threads:[~2026-02-23 7:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-21 19:01 [PATCH v2 00/11] staging: stl8723bs: Various cleanups Priit Laes
2026-02-21 19:01 ` [PATCH v2 01/11] staging: stl8723bs: Use common round_up macro Priit Laes
2026-02-21 19:41 ` Vivek BalachandharTN
2026-02-23 7:09 ` Dan Carpenter
2026-02-23 10:43 ` Priit Laes
2026-02-23 11:40 ` Julia Lawall
2026-02-23 11:50 ` Andy Shevchenko
2026-02-23 12:16 ` Julia Lawall
2026-02-23 13:48 ` Andy Shevchenko
2026-02-23 14:43 ` Dan Carpenter
2026-02-21 19:01 ` [PATCH v2 02/11] staging: rtl8723bs: Remove unused BIT32..BIT36 definitions Priit Laes
2026-02-21 19:01 ` [PATCH v2 03/11] staging: rtl8723bs: Drop empty rtw_bug_check function Priit Laes
2026-02-21 19:01 ` [PATCH v2 04/11] staging: rtl8723bs: Remove unused rtw_sprintf macro Priit Laes
2026-02-21 19:01 ` [PATCH v2 05/11] staging: rtl8723bs: Drop unused _kfree(...) declaration Priit Laes
2026-02-21 19:01 ` [PATCH v2 06/11] staging: rtl8723bs: Get rid of unused _rtw_init_queue Priit Laes
2026-02-21 19:01 ` [PATCH v2 07/11] staging: rtl8723bs: Drop unused NDEV-related formatting macros Priit Laes
2026-02-21 19:01 ` [PATCH v2 08/11] staging: rtl8723bs: Drop workqueue wrapper functions Priit Laes
2026-02-21 19:01 ` [PATCH v2 09/11] staging: rtl8273bs: Simplify regulatory initialization functions Priit Laes
2026-02-23 7:17 ` Dan Carpenter
2026-02-21 19:01 ` [PATCH v2 10/11] staging: rtl8723bs: Clean up wrapper functions Priit Laes
2026-02-21 20:20 ` Vivek BalachandharTN
2026-02-23 7:25 ` Dan Carpenter
[not found] ` <CAPsOcukZNc3oR=FmAjCdC6NrUV=1CaggQNGPoC2oxuH_P2R0hQ@mail.gmail.com>
2026-02-23 7:50 ` Andy Shevchenko
2026-02-21 19:01 ` [PATCH v2 11/11] staging: rtl8723bs: rtw_ieee80211: Reduce global symbols Priit Laes
2026-02-23 7:32 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZwCj4WEeS_B3FzF@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=abrahamadekunle50@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=architanant5@gmail.com \
--cc=arthur.stupa@gmail.com \
--cc=dikshakdevgan@gmail.com \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=julia.lawall@inria.fr \
--cc=karanja99erick@gmail.com \
--cc=karthikey3608@gmail.com \
--cc=khushalchitturi@gmail.com \
--cc=knavaneeth786@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lizhuoheng@kylinos.cn \
--cc=mingo@kernel.org \
--cc=ninozhang001@gmail.com \
--cc=plaes@plaes.org \
--cc=rdunlap@infradead.org \
--cc=rfp2005@gmail.com \
--cc=s9430939@naver.com \
--cc=straube.linux@gmail.com \
--cc=strnad.jj@gmail.com \
--cc=sun.jian.kdev@gmail.com \
--cc=suunj1331@gmail.com \
--cc=tanjimkamal1@gmail.com \
--cc=tehsiu.huang@gmail.com \
--cc=tglx@kernel.org \
--cc=vivek.balachandhar@gmail.com \
--cc=weibu@redadmin.org \
--cc=william.hansen.baird@gmail.com \
--cc=ysinghcin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox