From: Samyak Bambole <samyak.bambole07@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vme_user: use kmalloc_obj instead of kmalloc
Date: Sat, 14 Feb 2026 21:40:31 +0530 [thread overview]
Message-ID: <aa06f89b-8ec7-4ddd-b021-a5568b587480@gmail.com> (raw)
In-Reply-To: <2026021417-coconut-liking-b9db@gregkh>
On 2/14/26 9:32 PM, Greg KH wrote:
> On Sat, Feb 14, 2026 at 09:21:57PM +0530, Samyak wrote:
>> From: Samyak Bambole <samyak.bambole07@gmail.com>
>>
>> Replace kmalloc(sizeof(*ptr), GFP_KERNEL) calls with kmalloc_obj(*ptr,
>> GFP_KERNEL)
>>
>> This addresses scripts/checkpatch.pl warnings and follows the preffered
>> allocation pattern.
>
> This is a new thing, right? Are we going to be doing this for all
> staging drivers going forward?
Yeah I'm pretty sure it is relatively new, it was documented in
Documentation/process/deprecated.rst.
I would be happy to make this replacement in other staging drivers if
that would be useful
>
>> Changes:
>> - vme.c: 12 replacements
>> - vme_fake.c: 3 replacements
>> - vme_tsi148.c: 7 replacements
>
> There's no need for these lines in the changelog text, sorry. Can you
> fix that up and resend a v2?
>
> thanks,
>
> greg k-h
Thanks for the feedback, I'll make the modifications and send a v2.
Thanks,
Samyak Bambole
prev parent reply other threads:[~2026-02-14 16:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-14 15:51 [PATCH] staging: vme_user: use kmalloc_obj instead of kmalloc Samyak
2026-02-14 16:02 ` Greg KH
2026-02-14 16:10 ` Samyak Bambole [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa06f89b-8ec7-4ddd-b021-a5568b587480@gmail.com \
--to=samyak.bambole07@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox