From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38E884A29; Wed, 26 Mar 2025 08:26:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.134.164.104 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742977604; cv=none; b=VgIQPJbHprr4h91K6R0FHuH2fmBn1U93oRzxi45CXPCD2yHXIAT0JqKWsN0kfROCe8HFEl0nnYPBhcNryyvNbfL9pmWT11wcF790etN1fSGjtaPBzud/IilJXxbopbY6zVeK+30gjM6VhCNfwJjv3TRE2VpW7bBSKM123i3hSdw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742977604; c=relaxed/simple; bh=jSYdUxL251B4lgrd/EX2MMj+JgXoikIFSh9ZUwTxupQ=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=QAeDJQWU9OT18OIxLiqEQa7ZpaFRC4VNpz0X+ftgabEpf3Z0nUdQlhuW+FUO2GrLiYznSg3rU/AEtSzYDhSpoX9XW90dZnnjTLgFe7d5g/LvSrDFR8s/JTF+HCdGtuaF3m28ttE4j/ISIzYZx4IatPPBFF6OrPuAfgH44JiQiZ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr; spf=pass smtp.mailfrom=inria.fr; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b=tuiXj/gH; arc=none smtp.client-ip=192.134.164.104 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=inria.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b="tuiXj/gH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=BriUsCVdI6tKg9yDZ7xtoChU3hkuye0o+GkygCG2cZs=; b=tuiXj/gHhiP+M9LgO+QCA/HB4K8LMbEMEz03y0Igx8en2s/rc1G9HnI7 FwrXJ68ANyWpWBvH44g68NsVkv5tlwzjcDp+0qkIBMe7efb/r/37BZBLu 4frUGqBb+Bzt64FBAG/MwVdRHTQlZTe/NfDjxl683pWP49mbaKV77Est/ s=; Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="6.14,277,1736809200"; d="scan'208";a="112617095" Received: from dt-lawall.paris.inria.fr ([128.93.67.65]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2025 09:26:39 +0100 Date: Wed, 26 Mar 2025 09:26:38 +0100 (CET) From: Julia Lawall To: Abraham Samuel Adekunle cc: Greg Kroah-Hartman , outreachy@lists.linux.dev, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: remove braces around single statements In-Reply-To: Message-ID: References: Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 25 Mar 2025, Abraham Samuel Adekunle wrote: > The code contains braces around single statements in the if blocks > which are unnecessary according to the Linux kernel coding style. > > Remove the braces to improve readability and maintain consistency. > > Reported by checkpatch: > > WARNING: braces {} are not necessary for single statement blocks > > Signed-off-by: Abraham Samuel Adekunle > --- > drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c > index c60e179bb2e1..b17b295e8d3c 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c > +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c > @@ -56,9 +56,9 @@ int _ips_leave(struct adapter *padapter) > pwrpriv->ips_leave_cnts++; > > result = rtw_ips_pwr_up(padapter); > - if (result == _SUCCESS) { > + if (result == _SUCCESS) > pwrpriv->rf_pwrstate = rf_on; > - } > + I'm not sure you need to add a blank line here? julia > pwrpriv->bips_processing = false; > > pwrpriv->bkeepfwalive = false; > @@ -549,9 +549,8 @@ void LeaveAllPowerSaveMode(struct adapter *Adapter) > > LPS_Leave_check(Adapter); > } else { > - if (adapter_to_pwrctl(Adapter)->rf_pwrstate == rf_off) { > + if (adapter_to_pwrctl(Adapter)->rf_pwrstate == rf_off) > ips_leave(Adapter); > - } > } > } > > -- > 2.34.1 > > >