* [PATCH] staging: rtl8723bs: hal: remove unnecessary braces
@ 2026-03-06 16:11 Gopi Krishna Menon
2026-03-07 20:20 ` Bera Yüzlü
0 siblings, 1 reply; 5+ messages in thread
From: Gopi Krishna Menon @ 2026-03-06 16:11 UTC (permalink / raw)
To: gregkh
Cc: Gopi Krishna Menon, daniel.baluta, simona.toaca, karanja99erick,
benjaminpotron, linux-staging, linux-kernel
Checkpatch reports the following warning in odm_DIG.c
WARNING: braces {} are not necessary for single statement blocks
Remove unnecessary braces from single line conditional statements in
odm_DIG.c to fix checkpatch warning.
Signed-off-by: Gopi Krishna Menon <krishnagopi487@gmail.com>
---
Changes have been compile tested. No functionality change intended
drivers/staging/rtl8723bs/hal/odm_DIG.c | 28 +++++++++----------------
1 file changed, 10 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/odm_DIG.c b/drivers/staging/rtl8723bs/hal/odm_DIG.c
index f10427abd849..33661182d85a 100644
--- a/drivers/staging/rtl8723bs/hal/odm_DIG.c
+++ b/drivers/staging/rtl8723bs/hal/odm_DIG.c
@@ -220,9 +220,8 @@ void odm_Adaptivity(void *pDM_VOID, u8 IGI)
s8 Diff, IGI_target;
bool EDCCA_State = false;
- if (!(pDM_Odm->SupportAbility & ODM_BB_ADAPTIVITY)) {
+ if (!(pDM_Odm->SupportAbility & ODM_BB_ADAPTIVITY))
return;
- }
if (*pDM_Odm->pBandWidth == ODM_BW20M) /* CHANNEL_WIDTH_20 */
IGI_target = pDM_Odm->IGI_Base;
@@ -286,16 +285,14 @@ void ODM_Write_DIG(void *pDM_VOID, u8 CurrentIGI)
struct dm_odm_t *pDM_Odm = (struct dm_odm_t *)pDM_VOID;
struct dig_t *pDM_DigTable = &pDM_Odm->DM_DigTable;
- if (pDM_DigTable->bStopDIG) {
+ if (pDM_DigTable->bStopDIG)
return;
- }
if (pDM_DigTable->CurIGValue != CurrentIGI) {
/* 1 Check initial gain by upper bound */
if (!pDM_DigTable->bPSDInProgress) {
- if (CurrentIGI > pDM_DigTable->rx_gain_range_max) {
+ if (CurrentIGI > pDM_DigTable->rx_gain_range_max)
CurrentIGI = pDM_DigTable->rx_gain_range_max;
- }
}
@@ -314,24 +311,20 @@ bool odm_DigAbort(void *pDM_VOID)
struct dm_odm_t *pDM_Odm = (struct dm_odm_t *)pDM_VOID;
/* SupportAbility */
- if (!(pDM_Odm->SupportAbility & ODM_BB_FA_CNT)) {
+ if (!(pDM_Odm->SupportAbility & ODM_BB_FA_CNT))
return true;
- }
/* SupportAbility */
- if (!(pDM_Odm->SupportAbility & ODM_BB_DIG)) {
+ if (!(pDM_Odm->SupportAbility & ODM_BB_DIG))
return true;
- }
/* ScanInProcess */
- if (*(pDM_Odm->pbScanInProcess)) {
+ if (*(pDM_Odm->pbScanInProcess))
return true;
- }
/* add by Neil Chen to avoid PSD is processing */
- if (pDM_Odm->bDMInitialGainEnable == false) {
+ if (pDM_Odm->bDMInitialGainEnable == false)
return true;
- }
return false;
}
@@ -413,9 +406,9 @@ void odm_DIG(void *pDM_VOID)
if (pDM_Odm->bLinked && bPerformance) {
/* 2 Modify DIG upper bound */
/* 4 Modify DIG upper bound for 92E, 8723A\B, 8821 & 8812 BT */
- if (pDM_Odm->bBtLimitedDig == 1) {
+ if (pDM_Odm->bBtLimitedDig == 1)
offset = 10;
- } else
+ else
offset = 15;
if ((pDM_Odm->RSSI_Min + offset) > dm_dig_max)
@@ -475,9 +468,8 @@ void odm_DIG(void *pDM_VOID)
}
/* 2 Abnormal lower bound case */
- if (pDM_DigTable->rx_gain_range_min > pDM_DigTable->rx_gain_range_max) {
+ if (pDM_DigTable->rx_gain_range_min > pDM_DigTable->rx_gain_range_max)
pDM_DigTable->rx_gain_range_min = pDM_DigTable->rx_gain_range_max;
- }
/* 1 False alarm threshold decision */
--
2.52.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] staging: rtl8723bs: hal: remove unnecessary braces
2026-03-06 16:11 [PATCH] staging: rtl8723bs: hal: remove unnecessary braces Gopi Krishna Menon
@ 2026-03-07 20:20 ` Bera Yüzlü
2026-03-08 3:16 ` [PATCH v2] staging: rtl8723bs: " Gopi Krishna Menon
0 siblings, 1 reply; 5+ messages in thread
From: Bera Yüzlü @ 2026-03-07 20:20 UTC (permalink / raw)
To: krishnagopi487
Cc: benjaminpotron, daniel.baluta, gregkh, karanja99erick,
linux-kernel, linux-staging, simona.toaca
Don't write hal in your subject. It must be:
[PATCH] staging: rtl8723bs: remove unnecessary braces
Otherwise your patch looks good.
Thanks,
Bera
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] staging: rtl8723bs: remove unnecessary braces
2026-03-07 20:20 ` Bera Yüzlü
@ 2026-03-08 3:16 ` Gopi Krishna Menon
2026-03-08 11:40 ` Bera Yüzlü
0 siblings, 1 reply; 5+ messages in thread
From: Gopi Krishna Menon @ 2026-03-08 3:16 UTC (permalink / raw)
To: gregkh, benjaminpotron, karanja99erick
Cc: Gopi Krishna Menon, daniel.baluta, simona.toaca, linux-staging,
linux-kernel, b9788213
Checkpatch reports the following warning in odm_DIG.c
WARNING: braces {} are not necessary for single statement blocks
Remove unnecessary braces from single line conditional statements in
odm_DIG.c to fix checkpatch warning.
Suggested-by: Bera Yüzlü <b9788213@gmail.com>
Signed-off-by: Gopi Krishna Menon <krishnagopi487@gmail.com>
---
Changelog:
- Remove hal from subject line as suggested by Bera Yüzlü
drivers/staging/rtl8723bs/hal/odm_DIG.c | 28 +++++++++----------------
1 file changed, 10 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/odm_DIG.c b/drivers/staging/rtl8723bs/hal/odm_DIG.c
index f10427abd849..33661182d85a 100644
--- a/drivers/staging/rtl8723bs/hal/odm_DIG.c
+++ b/drivers/staging/rtl8723bs/hal/odm_DIG.c
@@ -220,9 +220,8 @@ void odm_Adaptivity(void *pDM_VOID, u8 IGI)
s8 Diff, IGI_target;
bool EDCCA_State = false;
- if (!(pDM_Odm->SupportAbility & ODM_BB_ADAPTIVITY)) {
+ if (!(pDM_Odm->SupportAbility & ODM_BB_ADAPTIVITY))
return;
- }
if (*pDM_Odm->pBandWidth == ODM_BW20M) /* CHANNEL_WIDTH_20 */
IGI_target = pDM_Odm->IGI_Base;
@@ -286,16 +285,14 @@ void ODM_Write_DIG(void *pDM_VOID, u8 CurrentIGI)
struct dm_odm_t *pDM_Odm = (struct dm_odm_t *)pDM_VOID;
struct dig_t *pDM_DigTable = &pDM_Odm->DM_DigTable;
- if (pDM_DigTable->bStopDIG) {
+ if (pDM_DigTable->bStopDIG)
return;
- }
if (pDM_DigTable->CurIGValue != CurrentIGI) {
/* 1 Check initial gain by upper bound */
if (!pDM_DigTable->bPSDInProgress) {
- if (CurrentIGI > pDM_DigTable->rx_gain_range_max) {
+ if (CurrentIGI > pDM_DigTable->rx_gain_range_max)
CurrentIGI = pDM_DigTable->rx_gain_range_max;
- }
}
@@ -314,24 +311,20 @@ bool odm_DigAbort(void *pDM_VOID)
struct dm_odm_t *pDM_Odm = (struct dm_odm_t *)pDM_VOID;
/* SupportAbility */
- if (!(pDM_Odm->SupportAbility & ODM_BB_FA_CNT)) {
+ if (!(pDM_Odm->SupportAbility & ODM_BB_FA_CNT))
return true;
- }
/* SupportAbility */
- if (!(pDM_Odm->SupportAbility & ODM_BB_DIG)) {
+ if (!(pDM_Odm->SupportAbility & ODM_BB_DIG))
return true;
- }
/* ScanInProcess */
- if (*(pDM_Odm->pbScanInProcess)) {
+ if (*(pDM_Odm->pbScanInProcess))
return true;
- }
/* add by Neil Chen to avoid PSD is processing */
- if (pDM_Odm->bDMInitialGainEnable == false) {
+ if (pDM_Odm->bDMInitialGainEnable == false)
return true;
- }
return false;
}
@@ -413,9 +406,9 @@ void odm_DIG(void *pDM_VOID)
if (pDM_Odm->bLinked && bPerformance) {
/* 2 Modify DIG upper bound */
/* 4 Modify DIG upper bound for 92E, 8723A\B, 8821 & 8812 BT */
- if (pDM_Odm->bBtLimitedDig == 1) {
+ if (pDM_Odm->bBtLimitedDig == 1)
offset = 10;
- } else
+ else
offset = 15;
if ((pDM_Odm->RSSI_Min + offset) > dm_dig_max)
@@ -475,9 +468,8 @@ void odm_DIG(void *pDM_VOID)
}
/* 2 Abnormal lower bound case */
- if (pDM_DigTable->rx_gain_range_min > pDM_DigTable->rx_gain_range_max) {
+ if (pDM_DigTable->rx_gain_range_min > pDM_DigTable->rx_gain_range_max)
pDM_DigTable->rx_gain_range_min = pDM_DigTable->rx_gain_range_max;
- }
/* 1 False alarm threshold decision */
--
2.52.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] staging: rtl8723bs: remove unnecessary braces
2026-03-08 3:16 ` [PATCH v2] staging: rtl8723bs: " Gopi Krishna Menon
@ 2026-03-08 11:40 ` Bera Yüzlü
2026-03-09 0:52 ` Gopi Krishna Menon
0 siblings, 1 reply; 5+ messages in thread
From: Bera Yüzlü @ 2026-03-08 11:40 UTC (permalink / raw)
To: krishnagopi487
Cc: b9788213, benjaminpotron, daniel.baluta, gregkh, karanja99erick,
linux-kernel, linux-staging, simona.toaca
Next time send your V2 as a new thread and after --- use version tags.
Look at this resource on how to make a v2:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
Thanks,
Bera
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] staging: rtl8723bs: remove unnecessary braces
2026-03-08 11:40 ` Bera Yüzlü
@ 2026-03-09 0:52 ` Gopi Krishna Menon
0 siblings, 0 replies; 5+ messages in thread
From: Gopi Krishna Menon @ 2026-03-09 0:52 UTC (permalink / raw)
To: Bera Yüzlü
Cc: benjaminpotron, daniel.baluta, gregkh, karanja99erick,
linux-kernel, linux-staging, simona.toaca
Hi Bera,
Thanks a lot for sharing the post on making a v2. Will make sure to follow the
guidelines as specified by Dan in the in future patches.
Thanks,
Gopi Krishna Menon
On Sun, Mar 08, 2026 at 02:40:02PM +0300, Bera Yüzlü wrote:
> Next time send your V2 as a new thread and after --- use version tags.
> Look at this resource on how to make a v2:
>
> https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
>
> Thanks,
> Bera
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-03-09 0:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-06 16:11 [PATCH] staging: rtl8723bs: hal: remove unnecessary braces Gopi Krishna Menon
2026-03-07 20:20 ` Bera Yüzlü
2026-03-08 3:16 ` [PATCH v2] staging: rtl8723bs: " Gopi Krishna Menon
2026-03-08 11:40 ` Bera Yüzlü
2026-03-09 0:52 ` Gopi Krishna Menon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox