From: Dan Carpenter <dan.carpenter@linaro.org>
To: dipesh chaudhary <me@dipeshchaudhary.in>
Cc: gregkh@linuxfoundation.org, trohan2000@gmail.com,
s9430939@naver.com, ethantidmore06@gmail.com,
davidzalman.101@gmail.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: replace comparison to false with logical NOT
Date: Mon, 9 Mar 2026 14:05:25 +0300 [thread overview]
Message-ID: <aa6pdbWTD9R6xaoW@stanley.mountain> (raw)
In-Reply-To: <0c3a1503-1af9-4507-b386-741c26c329ac@smtp-relay.sendinblue.com>
On Mon, Mar 09, 2026 at 10:48:23AM +0000, dipesh chaudhary wrote:
>
> Fix checkpatch warning "Using comparison to false is error prone". Replace "== false" with the logical NOT operator "!" to align with the standard Linux kernel coding style and improve readability.
>
> Signed-off-by: dipesh chaudhary <me@dipeshchaudhary.in>
> ---
Probably you should capitalize your name. It's supposed to be formal
like signeing a legal document.
Run your patch through checkpatch.
Someone already did this change. Work against the staging-next tree.
regards,
dan carpenter
next parent reply other threads:[~2026-03-09 11:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0c3a1503-1af9-4507-b386-741c26c329ac@smtp-relay.sendinblue.com>
2026-03-09 11:05 ` Dan Carpenter [this message]
[not found] <ea785b73-b972-4bac-b666-b6dce56fb393@smtp-relay.sendinblue.com>
2026-03-09 16:52 ` [PATCH] staging: rtl8723bs: replace comparison to false with logical NOT Greg KH
2026-03-09 12:51 Dipesh Chaudhary
-- strict thread matches above, loose matches on Subject: below --
2026-03-09 10:48 dipesh chaudhary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa6pdbWTD9R6xaoW@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=davidzalman.101@gmail.com \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=me@dipeshchaudhary.in \
--cc=s9430939@naver.com \
--cc=trohan2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox