[PATCH] staging: rtl8723bs: replace comparison to false with logical NOT

[PATCH] staging: rtl8723bs: replace comparison to false with logical NOT

[dipesh chaudhary]

Fix checkpatch warning "Using comparison to false is error prone". Replace "== false" with the logical NOT operator "!" to align with the standard Linux kernel coding style and improve readability.

Signed-off-by: dipesh chaudhary <me@dipeshchaudhary.in>
---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index 864cd8b6d1f1..8f18175175ee 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -1013,10 +1013,10 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 
 		rtw_ht_use_default_setting(padapter);
 
-		if (pmlmepriv->htpriv.sgi_20m == false)
+		if (!pmlmepriv->htpriv.sgi_20m)
 			pht_cap->cap_info &= cpu_to_le16(~(IEEE80211_HT_CAP_SGI_20));
 
-		if (pmlmepriv->htpriv.sgi_40m == false)
+		if (!pmlmepriv->htpriv.sgi_40m)
 			pht_cap->cap_info &= cpu_to_le16(~(IEEE80211_HT_CAP_SGI_40));
 
 		if (!TEST_FLAG(pmlmepriv->htpriv.ldpc_cap, LDPC_HT_ENABLE_RX))
-- 
2.47.3

Re: [PATCH] staging: rtl8723bs: replace comparison to false with logical NOT

[Dan Carpenter]

On Mon, Mar 09, 2026 at 10:48:23AM +0000, dipesh chaudhary wrote:
> 
> Fix checkpatch warning "Using comparison to false is error prone". Replace "== false" with the logical NOT operator "!" to align with the standard Linux kernel coding style and improve readability.
> 
> Signed-off-by: dipesh chaudhary <me@dipeshchaudhary.in>
> ---

Probably you should capitalize your name.  It's supposed to be formal
like signeing a legal document.

Run your patch through checkpatch.

Someone already did this change.  Work against the staging-next tree.

regards,
dan carpenter

Re: [PATCH] staging: rtl8723bs: replace comparison to false with logical NOT

[Dipesh Chaudhary]

Hi Dan,

Thank you for the review and the guidance. I have updated my Git configuration to properly capitalize my name for the Signed-off-by tag, and I will make sure to run checkpatch on the generated `.patch` files going forward.

I just added the staging tree as a remote and switched to `staging-next` to ensure I'm working against the latest codebase. I appreciate your patience with a newcomer!

Best regards,
Dipesh Chaudhary

Re: [PATCH] staging: rtl8723bs: replace comparison to false with logical NOT

[Greg KH]

On Mon, Mar 09, 2026 at 10:48:23AM +0000, dipesh chaudhary wrote:
> 
> Fix checkpatch warning "Using comparison to false is error prone". Replace "== false" with the logical NOT operator "!" to align with the standard Linux kernel coding style and improve readability.

Please wrap your changelog lines properly

> Signed-off-by: dipesh chaudhary <me@dipeshchaudhary.in>

And use Upper Case letters for your name :)

thanks,

greg k-h