From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Laur <laurentiutopai2004@gmail.com>,
hansg@kernel.org, mchehab@kernel.org, gregkh@linuxfoundation.org,
andy@kernel.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: media: atomisp: comprehensive coding style cleanup
Date: Mon, 9 Mar 2026 13:17:35 +0200 [thread overview]
Message-ID: <aa6sT1TwsPeNWRFQ@ashevche-desk.local> (raw)
In-Reply-To: <aa6fMZaAvMK-CyzL@kekkonen.localdomain>
On Mon, Mar 09, 2026 at 12:21:37PM +0200, Sakari Ailus wrote:
> On Sun, Mar 08, 2026 at 11:58:40PM +0200, Laur wrote:
> > @@ -2032,7 +2032,7 @@ static unsigned int long copy_from_compatible(void *to, const void *from,
> > {
> > if (from_user)
> > return copy_from_user(to, (void __user *)from, n);
> > - else
> > +
> > memcpy(to, from, n);
>
> The indentation is wrong here after the change.
>
> > return 0;
This code probably should be changed to use iov_iter facilities.
See the ALSA driver conversions for that, exempli gratia the commit
49aa6ed94c5e ("ALSA: korg1212: Convert to generic PCM copy ops").
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-03-09 11:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-08 21:58 [PATCH] staging: media: atomisp: comprehensive coding style cleanup Laur
2026-03-08 22:13 ` Andy Shevchenko
2026-03-09 10:17 ` kernel test robot
2026-03-09 10:21 ` Sakari Ailus
2026-03-09 11:17 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa6sT1TwsPeNWRFQ@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=laurentiutopai2004@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox