public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
* [PATCH] staging: rtl8723bs: Wrap long comments to fit line length
@ 2026-02-26 10:31 Mariyam Shahid
  2026-02-26 10:51 ` Dan Carpenter
  0 siblings, 1 reply; 3+ messages in thread
From: Mariyam Shahid @ 2026-02-26 10:31 UTC (permalink / raw)
  To: gregkh
  Cc: straube.linux, dan.carpenter, linux-staging, linux-kernel,
	Mariyam Shahid

Wrap comments exceeding 100 columns across multiple lines
to fix checkpatch warnings.

Signed-off-by: Mariyam Shahid <mariyam.shahid135@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_mlme.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index b090d162b37f..4dfa98239f9d 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -1022,7 +1022,7 @@ static struct sta_info *rtw_joinbss_update_stainfo(struct adapter *padapter, str
 		}
 
 		/* for A-MPDU Rx reordering buffer control for bmc_sta & sta_info */
-		/* if A-MPDU Rx is enabled, resetting rx_ordering_ctrl wstart_b(indicate_seq) 
+		/* if A-MPDU Rx is enabled, resetting rx_ordering_ctrl wstart_b(indicate_seq)
 		 * to default value = 0xffff
 		 */
 		/* todo: check if AP can send A-MPDU packets */
@@ -1041,7 +1041,7 @@ static struct sta_info *rtw_joinbss_update_stainfo(struct adapter *padapter, str
 				preorder_ctrl->enable = false;
 				preorder_ctrl->indicate_seq = 0xffff;
 				preorder_ctrl->wend_b = 0xffff;
-				/* max_ampdu_sz;ex. 32(kbytes) -> wsize_b =32 */				
+				/* max_ampdu_sz;ex. 32(kbytes) -> wsize_b =32 */
 				preorder_ctrl->wsize_b = 64;
 			}
 		}
@@ -1070,7 +1070,8 @@ static void rtw_joinbss_update_network(struct adapter *padapter, struct wlan_net
 	padapter->recvpriv.signal_strength = ptarget_wlan->network.phy_info.signal_strength;
 	padapter->recvpriv.signal_qual = ptarget_wlan->network.phy_info.signal_quality;
 	/* the ptarget_wlan->network.rssi is raw data,
-	 * we use ptarget_wlan->network.phy_info.signal_strength instead (has scaled) */
+	 * we use ptarget_wlan->network.phy_info.signal_strength instead (has scaled)
+	 */
 	padapter->recvpriv.rssi = translate_percentage_to_dbm(ptarget_wlan->network.phy_info.signal_strength);
 
 	rtw_set_signal_stat_timer(&padapter->recvpriv);
@@ -1243,7 +1244,7 @@ void rtw_joinbss_event_prehandle(struct adapter *adapter, u8 *pbuf)
 
 			/* s3. find ptarget_sta & update ptarget_sta after update cur_network
 			 * only for station mode
-			 * */
+			 */
 			if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) {
 				ptarget_sta = rtw_joinbss_update_stainfo(adapter, pnetwork);
 				if (!ptarget_sta) {
@@ -1375,7 +1376,7 @@ void rtw_stassoc_event_callback(struct adapter *adapter, u8 *pbuf)
 	if (psta) {
 		/* the sta have been in sta_info_queue => do nothing */
 
-		/* between drv has received this event before and 
+		/* between drv has received this event before and
 		 * fw have not yet to set key to CAM_ENTRY)
 		 */
 		return;
@@ -2182,7 +2183,7 @@ void rtw_update_registrypriv_dev_network(struct adapter *adapter)
 	struct wlan_bssid_ex    *pdev_network = &pregistrypriv->dev_network;
 	struct	security_priv *psecuritypriv = &adapter->securitypriv;
 	struct	wlan_network	*cur_network = &adapter->mlmepriv.cur_network;
-	
+
 	/* adhoc no 802.1x  */
 	pdev_network->privacy = (psecuritypriv->dot11PrivacyAlgrthm > 0 ? 1 : 0);
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: rtl8723bs: Wrap long comments to fit line length
  2026-02-26 10:31 [PATCH] staging: rtl8723bs: Wrap long comments to fit line length Mariyam Shahid
@ 2026-02-26 10:51 ` Dan Carpenter
  2026-02-27  7:25   ` Mariyam Shahid
  0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2026-02-26 10:51 UTC (permalink / raw)
  To: Mariyam Shahid; +Cc: gregkh, straube.linux, linux-staging, linux-kernel

On Thu, Feb 26, 2026 at 03:31:20PM +0500, Mariyam Shahid wrote:
> Wrap comments exceeding 100 columns across multiple lines
> to fix checkpatch warnings.
> 

Not even one of these changes has to do with the 100 character limit.
Please, split them up so you fix one type of warning per patch.

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: rtl8723bs: Wrap long comments to fit line length
  2026-02-26 10:51 ` Dan Carpenter
@ 2026-02-27  7:25   ` Mariyam Shahid
  0 siblings, 0 replies; 3+ messages in thread
From: Mariyam Shahid @ 2026-02-27  7:25 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Greg Kroah-Hartman, Michael Straube, linux-staging, linux-kernel

On Thu, 26 Feb 2026, 15:51 Dan Carpenter, <dan.carpenter@linaro.org> wrote:
>
> On Thu, Feb 26, 2026 at 03:31:20PM +0500, Mariyam Shahid wrote:
> > Wrap comments exceeding 100 columns across multiple lines
> > to fix checkpatch warnings.
> >
>
> Not even one of these changes has to do with the 100 character limit.
> Please, split them up so you fix one type of warning per patch.
>
> regards,
> dan carpenter
>

Thank you for the review. I will split the patches and fix the commit
message in v2.
regards,
Mariyam Shahid

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-02-27  7:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-26 10:31 [PATCH] staging: rtl8723bs: Wrap long comments to fit line length Mariyam Shahid
2026-02-26 10:51 ` Dan Carpenter
2026-02-27  7:25   ` Mariyam Shahid

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox