public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Dhyan K Prajapati <dhyan19022009@gmail.com>
To: Ethan Tidmore <ethantidmore06@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev, Jason Donenfeld <Jason@zx2c4.com>
Subject: Re: [PATCH] staging: rtl8723bs: fix function header alignment
Date: Fri, 27 Feb 2026 10:27:35 +0530	[thread overview]
Message-ID: <aaEkPx1LbV57c9VK@latitude> (raw)
In-Reply-To: <DGPDSKXS6NJH.3MWCJMW7KLGW4@gmail.com>

On Thu, Feb 26, 2026 at 08:16:38PM -0600, Ethan Tidmore wrote:
>On Wed Feb 25, 2026 at 2:57 AM CST, Dhyan K Prajapati wrote:
>> fixed header alignment in hal_sdio_get_cmd_addr_8723b that violated
>> kernel coding style, cleaned the header by pulling arguments onto the
>> same line.
>>
>> Signed-off-by: Dhyan K Prajapati <dhyan19022009@gmail.com>
>> ---
>
>LGTM. However, next time say parameter alignment instead of header. Was
>a little confused what you meant at first until I read your subject
>line.
>
>Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
>
>Thanks,
>
>ET

seconded, i'll keep that in mind the next time.

      reply	other threads:[~2026-02-27  4:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25  8:57 [PATCH] staging: rtl8723bs: fix function header alignment Dhyan K Prajapati
2026-02-27  2:16 ` Ethan Tidmore
2026-02-27  4:57   ` Dhyan K Prajapati [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaEkPx1LbV57c9VK@latitude \
    --to=dhyan19022009@gmail.com \
    --cc=Jason@zx2c4.com \
    --cc=ethantidmore06@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox