public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Nikolay Kulikov <nikolayof23@gmail.com>
To: Ethan Tidmore <ethantidmore06@gmail.com>
Cc: gregkh@linuxfoundation.org, dan.carpenter@linaro.org,
	linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: rtl8723bs: remove unused 'ratelen' parameter from rtw_check_network_type()
Date: Fri, 27 Feb 2026 18:26:16 +0300	[thread overview]
Message-ID: <aaG3mJqfNxZui8lw@archlinux> (raw)
In-Reply-To: <DGP0F87MHPIS.1IE1IQAR5Z8QB@gmail.com>

On Thu, Feb 26, 2026 at 09:47:57AM -0600, Ethan Tidmore wrote:
> On Thu Feb 26, 2026 at 8:10 AM CST, Nikolay Kulikov wrote:
> > The rtw_check_network_type() function takes a 'ratelen' parameter, but
> > does not use it in any way. Also remove the local variable in rtw_ap.c
> > created just to pass a value to this unused parameter.
> >
> > Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
> > ---
> 
> ...
> 
> 
> > @@ -890,7 +887,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
> >  		support_rate_num += ie_len;
> >  	}
> >  
> > -	network_type = rtw_check_network_type(support_rate, support_rate_num, channel);
> > +	network_type = rtw_check_network_type(support_rate, channel);
> 
> I think you can delete support_rate_num in this function too.

Is it possible to remove it completely? It's used as a temporary buffer
for 'ie_len', so perhaps just the last line that increments
'support_rate_num' can be removed:

> >  		support_rate_num += ie_len;

since this value is not used anywhere below.


Thanks,

Nikolay

  reply	other threads:[~2026-02-27 15:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-26 14:10 [PATCH] staging: rtl8723bs: remove unused 'ratelen' parameter from rtw_check_network_type() Nikolay Kulikov
2026-02-26 15:47 ` Ethan Tidmore
2026-02-27 15:26   ` Nikolay Kulikov [this message]
2026-02-27 17:38     ` Ethan Tidmore
2026-02-27 20:26       ` Ethan Tidmore
2026-02-28 13:09 ` [PATCH v2] " Nikolay Kulikov
2026-03-01 18:25   ` Ethan Tidmore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaG3mJqfNxZui8lw@archlinux \
    --to=nikolayof23@gmail.com \
    --cc=dan.carpenter@linaro.org \
    --cc=ethantidmore06@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox