Re: [PATCH v2 3/3] staging: axis-fifo: fix alignment and handle boolean properties

[Dan Carpenter <dan.carpenter@linaro.org>]

On Fri, Feb 27, 2026 at 03:10:45PM -0300, Lucas Faria Mendes wrote:
> Signed-off-by: Lucas Faria Mendes <lucas.fariamo08@gmail.com>
> ---
>  drivers/staging/axis-fifo/axis-fifo.c | 55 +++++++--------------------
>  1 file changed, 13 insertions(+), 42 deletions(-)
> 
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index c64a7249feca..4b2cab2f8357 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -387,66 +387,37 @@ static void axis_fifo_debugfs_init(struct axis_fifo *fifo)
>  
>  static int axis_fifo_parse_dt(struct axis_fifo *fifo)
>  {
> -	int ret;
> -	unsigned int value;
>  	struct device_node *node = fifo->dt_device->of_node;
> -
> -	ret = of_property_read_u32(node, "xlnx,axi-str-rxd-tdata-width",
> -				   &value);
> +	int ret;
> +	
> +	ret = of_property_read_u32(node, "xlnx,axi-str-rxd-tdata-width", &ret);
        ^^^                                                              ^^^^


>  	if (ret) {
>  		dev_err(fifo->dt_device, "missing xlnx,axi-str-rxd-tdata-width property\n");
> -		goto end;
> -	} else if (value != 32) {
> -		dev_err(fifo->dt_device, "xlnx,axi-str-rxd-tdata-width only supports 32 bits\n");
> -		ret = -EIO;
> -		goto end;
> +		return -EINVAL;
>  	}

What?  I'm so puzzled by this patch.  It's totally wrong.

regards,
dan carpenter