From: Dan Carpenter <dan.carpenter@linaro.org>
To: Jack Tanner <jtanner0786@gmail.com>
Cc: hansg@kernel.org, mchehab@kernel.org,
sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] media: atomisp: ov2722: move sensor init from set_fmt to s_stream
Date: Mon, 2 Mar 2026 12:03:18 +0300 [thread overview]
Message-ID: <aaVSVhKPxGzqyuPv@stanley.mountain> (raw)
In-Reply-To: <20260301041728.577647-2-jtanner0786@gmail.com>
On Sat, Feb 28, 2026 at 10:17:28PM -0600, Jack Tanner wrote:
> Move the sensor reset and register programming from ov2722_set_fmt()
> into ov2722_s_stream(), which is the correct place to initialize
> hardware. This removes the ov2722_startup() helper and its fragile
> retry loop that attempted to power cycle the sensor on failure.
>
> Signed-off-by: Jack Tanner <jtanner0786@gmail.com>
> ---
Okay, fine, retry loops are fragile but it was solving a real problem
but instead of replacing it you've just deleted it?
This feels like an AI patch. We've had a lot of people who 1) Find
a TODO and 2) Ask an AI to fix the TODO. But it's like, if the TODO
were so trivial that an AI could do it, then the original author could
have done it.
regards,
dan carpenter
prev parent reply other threads:[~2026-03-02 9:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-01 4:17 [PATCH] Add linux-next specific files for 20260227 Jack Tanner
2026-03-01 4:17 ` [PATCH] media: atomisp: ov2722: move sensor init from set_fmt to s_stream Jack Tanner
2026-03-02 9:03 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaVSVhKPxGzqyuPv@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=jtanner0786@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox