From: Dan Carpenter <dan.carpenter@linaro.org>
To: Luis Soza Rodriguez <luistermc789@gmail.com>
Cc: pure.logic@nexus-software.ie, johan@kernel.org, elder@kernel.org,
gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Luis Soza Rodriguez <contact@sluisr.com>
Subject: Re: [PATCH v2] staging: greybus: loopback: use sysfs_emit in sysfs show functions
Date: Tue, 10 Mar 2026 10:27:34 +0300 [thread overview]
Message-ID: <aa_H5txp-dOmmqJ-@stanley.mountain> (raw)
In-Reply-To: <20260309230507.4931-1-contact@sluisr.com>
On Mon, Mar 09, 2026 at 05:05:07PM -0600, Luis Soza Rodriguez wrote:
> As per the kernel's documentation, sysfs_emit() is the preferred way
> to format strings for sysfs attributes. It handles buffer overruns
> safely. Replace sprintf calls with sysfs_emit across all loopback
> sysfs show macros.
>
> Signed-off-by: Luis Soza Rodriguez <contact@sluisr.com>
> ---
> v2: align backslashes in macros as requested by Dan Carpenter.
>
Thanks.
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
regards,
dan carpenter
prev parent reply other threads:[~2026-03-10 7:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 23:05 [PATCH v2] staging: greybus: loopback: use sysfs_emit in sysfs show functions Luis Soza Rodriguez
2026-03-10 7:27 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa_H5txp-dOmmqJ-@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=contact@sluisr.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=luistermc789@gmail.com \
--cc=pure.logic@nexus-software.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox