public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Ethan Tidmore <ethantidmore06@gmail.com>
Cc: "Jose A. Perez de Azpillaga" <azpijr@gmail.com>,
	linux-staging@lists.linux.dev,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Khushal Chitturi" <khushalchitturi@gmail.com>,
	"Thomas Gleixner" <tglx@kernel.org>,
	"Ingo Molnar" <mingo@kernel.org>,
	"Rogério Fernandes Pereira" <rfp2005@gmail.com>,
	"Abraham Samuel Adekunle" <abrahamadekunle50@gmail.com>,
	"Artur Stupa" <arthur.stupa@gmail.com>,
	"Zhuoheng Li" <lizhuoheng@kylinos.cn>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] staging: rtl8723bs: remove redundant blank lines
Date: Wed, 4 Mar 2026 11:08:43 +0300	[thread overview]
Message-ID: <aafoiy8e53XRfg7F@stanley.mountain> (raw)
In-Reply-To: <DGTHUZ568F1W.1OBYQ16QVDYLL@gmail.com>

On Tue, Mar 03, 2026 at 04:18:30PM -0600, Ethan Tidmore wrote:
> On Tue Mar 3, 2026 at 11:38 AM CST, Jose A. Perez de Azpillaga wrote:
> > Remove multiple blank lines and unnecessary blank lines before closing
> > braces.
> >
> > Signed-off-by: Jose A. Perez de Azpillaga <azpijr@gmail.com>
> > ---
> >  drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 14 --------------
> >  1 file changed, 14 deletions(-)
> >
> 
> ...
> 
> >  		pwrpriv->rf_pwrstate = rf_off;
> >  	}
> >  	pwrpriv->bips_processing = false;
> > -
> >  }
> 
> Ideally since your deleting that blank line this would be something like
> this:
> 		pwr...
> 	}
> 
> 	pwrpriv->bips_processing = false;
> }

Sorry, I don't understand what you're trying to say.

regards,
dan carpenter


  parent reply	other threads:[~2026-03-04  8:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-03 17:38 [PATCH 0/4] staging: rtl8723bs: coding style cleanups Jose A. Perez de Azpillaga
2026-03-03 17:38 ` [PATCH 1/4] staging: rtl8723bs: remove redundant blank lines Jose A. Perez de Azpillaga
2026-03-03 22:18   ` Ethan Tidmore
2026-03-04  0:08     ` Ethan Tidmore
2026-03-04  8:08     ` Dan Carpenter [this message]
2026-03-04  9:00   ` Ethan Tidmore
2026-03-03 17:38 ` [PATCH 2/4] staging: rtl8723bs: format operators and logical continuations Jose A. Perez de Azpillaga
2026-03-03 22:30   ` Ethan Tidmore
2026-03-03 22:31     ` Ethan Tidmore
2026-03-03 17:38 ` [PATCH 3/4] staging: rtl8723bs: curly brace consistency Jose A. Perez de Azpillaga
2026-03-04  0:03   ` Ethan Tidmore
2026-03-03 17:38 ` [PATCH 4/4] staging: rtl8723bs: fix indentation, line length and declarations Jose A. Perez de Azpillaga
2026-03-04  0:07   ` Ethan Tidmore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aafoiy8e53XRfg7F@stanley.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=abrahamadekunle50@gmail.com \
    --cc=arthur.stupa@gmail.com \
    --cc=azpijr@gmail.com \
    --cc=ethantidmore06@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=khushalchitturi@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=lizhuoheng@kylinos.cn \
    --cc=mingo@kernel.org \
    --cc=rfp2005@gmail.com \
    --cc=tglx@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox