From: Dan Carpenter <dan.carpenter@linaro.org>
To: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: media: atomisp: circbuf: Fix leading space indentation
Date: Sat, 7 Mar 2026 17:33:06 +0300 [thread overview]
Message-ID: <aaw3IuOQbzPcAvcS@stanley.mountain> (raw)
In-Reply-To: <20260307113959.67116-2-giorgitchankvetadze1997@gmail.com>
On Sat, Mar 07, 2026 at 03:40:00PM +0400, Giorgi Tchankvetadze wrote:
> Fix lines starting with spaces instead of tabs to comply with
> kernel coding style.
>
> No functional change.
>
> Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
> ---
> .../staging/media/atomisp/pci/base/circbuf/src/circbuf.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c b/drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c
> index cb34d0b5abb5..9aa10cb1185d 100644
> --- a/drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c
> +++ b/drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c
> @@ -192,9 +192,9 @@ uint32_t ia_css_circbuf_peek_from_start(ia_css_circbuf_t *cb, int offset)
> * Please refer to "ia_css_circbuf.h" for details.
> */
> bool ia_css_circbuf_increase_size(
> - ia_css_circbuf_t *cb,
> - unsigned int sz_delta,
> - ia_css_circbuf_elem_t *elems)
> + ia_css_circbuf_t *cb,
> + unsigned int sz_delta,
> + ia_css_circbuf_elem_t *elems)
We would normally do it like this:
bool ia_css_circbuf_increase_size(ia_css_circbuf_t *cb, unsigned int sz_delta,
ia_css_circbuf_elem_t *elems)
regards,
dan carpenter
> {
> u8 curr_size;
> u8 curr_end;
> --
> 2.52.0
>
next prev parent reply other threads:[~2026-03-07 14:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-07 11:40 [PATCH] staging: media: atomisp: circbuf: Fix leading space indentation Giorgi Tchankvetadze
2026-03-07 14:33 ` Dan Carpenter [this message]
2026-03-09 5:45 ` Giorgi Tchankvetadze
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaw3IuOQbzPcAvcS@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=giorgitchankvetadze1997@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox