* [PATCH] staging: media: atomisp: circbuf: Fix leading space indentation
@ 2026-03-07 11:40 Giorgi Tchankvetadze
2026-03-07 14:33 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Giorgi Tchankvetadze @ 2026-03-07 11:40 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Giorgi Tchankvetadze
Fix lines starting with spaces instead of tabs to comply with
kernel coding style.
No functional change.
Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
---
.../staging/media/atomisp/pci/base/circbuf/src/circbuf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c b/drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c
index cb34d0b5abb5..9aa10cb1185d 100644
--- a/drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c
+++ b/drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c
@@ -192,9 +192,9 @@ uint32_t ia_css_circbuf_peek_from_start(ia_css_circbuf_t *cb, int offset)
* Please refer to "ia_css_circbuf.h" for details.
*/
bool ia_css_circbuf_increase_size(
- ia_css_circbuf_t *cb,
- unsigned int sz_delta,
- ia_css_circbuf_elem_t *elems)
+ ia_css_circbuf_t *cb,
+ unsigned int sz_delta,
+ ia_css_circbuf_elem_t *elems)
{
u8 curr_size;
u8 curr_end;
--
2.52.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: media: atomisp: circbuf: Fix leading space indentation
2026-03-07 11:40 [PATCH] staging: media: atomisp: circbuf: Fix leading space indentation Giorgi Tchankvetadze
@ 2026-03-07 14:33 ` Dan Carpenter
2026-03-09 5:45 ` Giorgi Tchankvetadze
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2026-03-07 14:33 UTC (permalink / raw)
To: Giorgi Tchankvetadze; +Cc: gregkh, linux-staging, linux-kernel
On Sat, Mar 07, 2026 at 03:40:00PM +0400, Giorgi Tchankvetadze wrote:
> Fix lines starting with spaces instead of tabs to comply with
> kernel coding style.
>
> No functional change.
>
> Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
> ---
> .../staging/media/atomisp/pci/base/circbuf/src/circbuf.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c b/drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c
> index cb34d0b5abb5..9aa10cb1185d 100644
> --- a/drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c
> +++ b/drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c
> @@ -192,9 +192,9 @@ uint32_t ia_css_circbuf_peek_from_start(ia_css_circbuf_t *cb, int offset)
> * Please refer to "ia_css_circbuf.h" for details.
> */
> bool ia_css_circbuf_increase_size(
> - ia_css_circbuf_t *cb,
> - unsigned int sz_delta,
> - ia_css_circbuf_elem_t *elems)
> + ia_css_circbuf_t *cb,
> + unsigned int sz_delta,
> + ia_css_circbuf_elem_t *elems)
We would normally do it like this:
bool ia_css_circbuf_increase_size(ia_css_circbuf_t *cb, unsigned int sz_delta,
ia_css_circbuf_elem_t *elems)
regards,
dan carpenter
> {
> u8 curr_size;
> u8 curr_end;
> --
> 2.52.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: media: atomisp: circbuf: Fix leading space indentation
2026-03-07 14:33 ` Dan Carpenter
@ 2026-03-09 5:45 ` Giorgi Tchankvetadze
0 siblings, 0 replies; 3+ messages in thread
From: Giorgi Tchankvetadze @ 2026-03-09 5:45 UTC (permalink / raw)
To: Dan Carpenter; +Cc: gregkh, linux-staging, linux-kernel
On Sat, Mar 7, 2026 at 6:33 PM Dan Carpenter <dan.carpenter@linaro.org> wrote:
> We would normally do it like this:
>
> bool ia_css_circbuf_increase_size(ia_css_circbuf_t *cb, unsigned int sz_delta,
> ia_css_circbuf_elem_t *elems)
Thanks for the review, Dan. Sent v2.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-09 5:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-07 11:40 [PATCH] staging: media: atomisp: circbuf: Fix leading space indentation Giorgi Tchankvetadze
2026-03-07 14:33 ` Dan Carpenter
2026-03-09 5:45 ` Giorgi Tchankvetadze
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox