From: Dan Carpenter <dan.carpenter@linaro.org>
To: Rachit Dhar <rchtdhr@gmail.com>
Cc: Viresh Kumar <vireshk@kernel.org>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rui Miguel Silva <rmfrfs@gmail.com>,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] staging: greybus: resolved checkpatch checks for light.c
Date: Sat, 7 Mar 2026 17:39:37 +0300 [thread overview]
Message-ID: <aaw4qSHE8c_YE_mn@stanley.mountain> (raw)
In-Reply-To: <20260307140930.1732-3-rchtdhr@gmail.com>
On Sat, Mar 07, 2026 at 02:09:25PM +0000, Rachit Dhar wrote:
> Added comments to mutex declarations, to resolve the associated checkpatch.pl checks:
>
> CHECK: struct mutex definition without comment
> + struct mutex lock;
>
> CHECK: struct mutex definition without comment
> + struct mutex lights_lock;
>
> Signed-off-by: Rachit Dhar <rchtdhr@gmail.com>
These kinds of things require more than a two word explanation. It
should probably be a paragraph. But first do a proper review of the
locking. When do we start needing to worry about concurrent accesses?
How is it accessed? What would happen if the locking were not there?
Is the unregister sequence correct?
regards,
dan carpenter
next prev parent reply other threads:[~2026-03-07 14:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-07 14:09 [PATCH v4 0/2] staging: greybus: fixing checkpatch issues Rachit Dhar
2026-03-07 14:09 ` [PATCH v4 1/2] staging: greybus: fixed styling issue in fw-management.c Rachit Dhar
2026-03-07 14:09 ` [PATCH v4 2/2] staging: greybus: resolved checkpatch checks for light.c Rachit Dhar
2026-03-07 14:39 ` Dan Carpenter [this message]
2026-03-07 14:44 ` Dan Carpenter
2026-03-08 18:48 ` [PATCH v4 0/2] staging: greybus: fixing checkpatch issues Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaw4qSHE8c_YE_mn@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=rchtdhr@gmail.com \
--cc=rmfrfs@gmail.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox