From: Dan Carpenter <dan.carpenter@linaro.org>
To: Marcos Andrade <marcosandrade95963@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] staging: rtl8723bs: rename rt_channel_info members to snake_case
Date: Sat, 21 Mar 2026 18:30:54 +0300 [thread overview]
Message-ID: <ab65rtwFqmzYSd4Z@stanley.mountain> (raw)
In-Reply-To: <20260321151342.19864-3-marcosandrade95963@gmail.com>
On Sat, Mar 21, 2026 at 03:13:41PM +0000, Marcos Andrade wrote:
> i++;
> j++;
> k++;
> - } else if (chplan_sta[i].ChannelNum < chplan_ap.Channel[j]) {
> - chplan_new[k].ChannelNum = chplan_sta[i].ChannelNum;
> - chplan_new[k].ScanType = SCAN_PASSIVE;
> + } else if (chplan_sta[i].channel_num < chplan_ap.Channel[j]) {
> + chplan_new[k].channel_num = chplan_sta[i].scan_type;
^^^^^^^^^
You changed this from .channel_num to .scan_type... Please, be more
careful.
regards,
dan carpenter
> + chplan_new[k].scan_type = SCAN_PASSIVE;
> i++;
> k++;
> - } else if (chplan_sta[i].ChannelNum > chplan_ap.Channel[j]) {
> - chplan_new[k].ChannelNum = chplan_ap.Channel[j];
> - chplan_new[k].ScanType = SCAN_ACTIVE;
> + } else if (chplan_sta[i].channel_num > chplan_ap.Channel[j]) {
> + chplan_new[k].channel_num = chplan_ap.Channel[j];
> + chplan_new[k].scan_type = SCAN_ACTIVE;
> j++;
> k++;
> }
next prev parent reply other threads:[~2026-03-21 15:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-21 15:13 [PATCH 0/3] rename rt_channel_info members to snake_case Marcos Andrade
2026-03-21 15:13 ` [PATCH 1/3] staging: rtl8723bs: " Marcos Andrade
2026-03-21 15:30 ` Dan Carpenter
2026-03-21 15:13 ` [PATCH 2/3] " Marcos Andrade
2026-03-21 15:30 ` Dan Carpenter [this message]
2026-03-21 15:13 ` [PATCH 3/3] staging: rtl8723bs: update rt_channel_info member usage to snake_case in wifi_reged.c Marcos Andrade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab65rtwFqmzYSd4Z@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=marcosandrade95963@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox