public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Souradipto Das <souradiptodas6@gmail.com>, gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: vme_user: add blank lines to struct fake_driver
Date: Tue, 14 Apr 2026 13:09:56 -0700	[thread overview]
Message-ID: <ab7fbf1b8bd1e6d8ff15fc5edd7e15bb79fd39ce.camel@perches.com> (raw)
In-Reply-To: <20260414173754.22890-1-souradiptodas6@gmail.com>

On Tue, 2026-04-14 at 17:37 +0000, Souradipto Das wrote:
> Fix checkpatch.pl warnings regarding missing blank lines after
> declarations. This improves readability by grouping related
> Location Monitor variables together.
> 
> Signed-off-by: Souradipto Das <[souradiptodas6@gmail.com](mailto:souradiptodas6@gmail.com)>
> ---
> 
> v3:
>   - Added this changelog (missing in v2).
>   - No changes to code itself.
> v2:
>   - Fixed author name/email to use real identity.
>   
>  drivers/staging/vme_user/vme_fake.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/vme_user/vme_fake.c b/drivers/staging/vme_user/vme_fake.c
> index be4ad47ed526..7ec14bf15fbe 100644
> --- a/drivers/staging/vme_user/vme_fake.c
> +++ b/drivers/staging/vme_user/vme_fake.c
> @@ -67,8 +67,10 @@ struct fake_driver {
>  	unsigned long long lm_base;
>  	u32 lm_aspace;
>  	u32 lm_cycle;
> +
>  	void (*lm_callback[4])(void *);
>  	void *lm_data[4];
> +
>  	struct tasklet_struct int_tasklet;
>  	int int_level;
>  	int int_statid;

The first blank line is a checkpatch false positive.
The second is not necessary.


      reply	other threads:[~2026-04-14 20:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-14 17:37 [PATCH v3] staging: vme_user: add blank lines to struct fake_driver Souradipto Das
2026-04-14 20:09 ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab7fbf1b8bd1e6d8ff15fc5edd7e15bb79fd39ce.camel@perches.com \
    --to=joe@perches.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=souradiptodas6@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox