From: Dan Carpenter <dan.carpenter@linaro.org>
To: "Jose A. Perez de Azpillaga" <azpijr@gmail.com>
Cc: linux-staging@lists.linux.dev,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Michael Straube <straube.linux@gmail.com>,
Hans de Goede <hansg@kernel.org>,
Khushal Chitturi <khushalchitturi@gmail.com>,
Luka Gejak <luka.gejak@linux.dev>,
Vivek BalachandharTN <vivek.balachandhar@gmail.com>,
Artur Stupa <arthur.stupa@gmail.com>,
Zhuoheng Li <lizhuoheng@kylinos.cn>,
Nino Zhang <ninozhang001@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/2] staging: rtl8723bs: clean up rtw_joinbss_event_prehandle
Date: Sun, 22 Mar 2026 00:27:36 +0300 [thread overview]
Message-ID: <ab8NSN0ypuc6WTmv@stanley.mountain> (raw)
In-Reply-To: <20260321182713.665872-1-azpijr@gmail.com>
On Sat, Mar 21, 2026 at 07:26:58PM +0100, Jose A. Perez de Azpillaga wrote:
> This series cleans up the rtw_joinbss_event_prehandle function in the
> rtl8723bs staging driver.
>
> The first patch removes dead code guarded by the REJOIN macro, which is
> never defined in the kernel. This simplifies the function before the
> subsequent refactor.
>
> The second patch refactors the function using guard clauses and early
> returns to reduce deep indentation, improving overall readability.
>
> v4:
> - Removed redundant return at the end of the void function.
> - Fixed typo in v3 cover letter. ("Rmoed" -> "Removed")
> - Picked up Reviewed-by tag from Luka Gejak.
Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
regards,
dan carpenter
prev parent reply other threads:[~2026-03-21 21:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-21 18:26 [PATCH v4 0/2] staging: rtl8723bs: clean up rtw_joinbss_event_prehandle Jose A. Perez de Azpillaga
2026-03-21 18:26 ` [PATCH v4 1/2] staging: rtl8723bs: remove dead REJOIN code Jose A. Perez de Azpillaga
2026-03-21 18:27 ` [PATCH v4 2/2] staging: rtl8723bs: refactor rtw_joinbss_event_prehandle to reduce indentation Jose A. Perez de Azpillaga
2026-03-21 21:27 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab8NSN0ypuc6WTmv@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=arthur.stupa@gmail.com \
--cc=azpijr@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=khushalchitturi@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lizhuoheng@kylinos.cn \
--cc=luka.gejak@linux.dev \
--cc=ninozhang001@gmail.com \
--cc=straube.linux@gmail.com \
--cc=vivek.balachandhar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox