From: Dan Carpenter <dan.carpenter@linaro.org>
To: "Bera Yüzlü" <b9788213@gmail.com>
Cc: gregkh@linuxfoundation.org, ethantidmore06@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: rtl8723bs: Improve error handling
Date: Mon, 16 Mar 2026 11:25:14 +0300 [thread overview]
Message-ID: <abe-aqobxwCIMj33@stanley.mountain> (raw)
In-Reply-To: <20260313163740.454-2-b9788213@gmail.com>
On Fri, Mar 13, 2026 at 07:37:41PM +0300, Bera Yüzlü wrote:
> Remove unnecessary ret variable and goto exit pattern. The function now
> returns immediately when an error occurs. Additionally, ensure that
> intf_free_irq() is called when pm_netdev_open() fails to avoid leaving
> the allocated IRQ uncleared.
>
> Signed-off-by: Bera Yüzlü <b9788213@gmail.com>
> ---
> V3: Fixed patch description.
> V2: Used int_free_irq() in error condition.
> V1 Link: https://lore.kernel.org/linux-staging/20260312131933.29505-2-b9788213@gmail.com/
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 28 ++++++++-------------
> 1 file changed, 10 insertions(+), 18 deletions(-)
I responded to v2. Same comments here.
regards,
dan carpenter
prev parent reply other threads:[~2026-03-16 8:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 16:37 [PATCH v3] staging: rtl8723bs: Improve error handling Bera Yüzlü
2026-03-16 8:25 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abe-aqobxwCIMj33@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=b9788213@gmail.com \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox