* [PATCH] staging: vme_user: add blank line after declarations in fake_driver struct
@ 2026-03-17 13:18 Teng Liu
2026-03-17 14:44 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Teng Liu @ 2026-03-17 13:18 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Teng Liu
Add a blank line between regular field declarations and function pointer
declarations in struct fake_driver to follow the kernel coding style
convention of separating declarations for improved readability.
This addresses the following checkpatch warning:
WARNING: Missing a blank line after declarations
Signed-off-by: Teng Liu <27rabbitlt@gmail.com>
---
drivers/staging/vme_user/vme_fake.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/vme_user/vme_fake.c b/drivers/staging/vme_user/vme_fake.c
index be4ad47ed..eb918a857 100644
--- a/drivers/staging/vme_user/vme_fake.c
+++ b/drivers/staging/vme_user/vme_fake.c
@@ -67,6 +67,7 @@ struct fake_driver {
unsigned long long lm_base;
u32 lm_aspace;
u32 lm_cycle;
+
void (*lm_callback[4])(void *);
void *lm_data[4];
struct tasklet_struct int_tasklet;
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: vme_user: add blank line after declarations in fake_driver struct
2026-03-17 13:18 [PATCH] staging: vme_user: add blank line after declarations in fake_driver struct Teng Liu
@ 2026-03-17 14:44 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2026-03-17 14:44 UTC (permalink / raw)
To: Teng Liu; +Cc: gregkh, linux-staging, linux-kernel
On Tue, Mar 17, 2026 at 02:18:22PM +0100, Teng Liu wrote:
> Add a blank line between regular field declarations and function pointer
> declarations in struct fake_driver to follow the kernel coding style
> convention of separating declarations for improved readability.
>
> This addresses the following checkpatch warning:
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Teng Liu <27rabbitlt@gmail.com>
> ---
> drivers/staging/vme_user/vme_fake.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/vme_user/vme_fake.c b/drivers/staging/vme_user/vme_fake.c
> index be4ad47ed..eb918a857 100644
> --- a/drivers/staging/vme_user/vme_fake.c
> +++ b/drivers/staging/vme_user/vme_fake.c
> @@ -67,6 +67,7 @@ struct fake_driver {
> unsigned long long lm_base;
> u32 lm_aspace;
> u32 lm_cycle;
> +
> void (*lm_callback[4])(void *);
This is in a struct, right? It's all declarations... Just ignore
checkpatch when it prints nonsense.
regards,
dan carpenter
> void *lm_data[4];
> struct tasklet_struct int_tasklet;
> --
> 2.53.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-17 14:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-17 13:18 [PATCH] staging: vme_user: add blank line after declarations in fake_driver struct Teng Liu
2026-03-17 14:44 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox