public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Aadarsh Mandal <aadarshmandal9354@gmail.com>
Cc: gregkh@linuxfoundation.org, luka.gejak@linux.dev,
	ethantidmore06@gmail.com, linux-kernel@vger.kernel.org,
	linux-staging@lists.linux.dev, straube.linux@gmail.com
Subject: Re: [PATCH v3] staging: rtl8723bs: remove dead code
Date: Wed, 18 Mar 2026 14:17:58 +0300	[thread overview]
Message-ID: <abqJ5kdM_OsgJohA@stanley.mountain> (raw)
In-Reply-To: <20260318104332.32093-1-aadarshmandal9354@gmail.com>

On Wed, Mar 18, 2026 at 04:13:31PM +0530, Aadarsh Mandal wrote:
> remove unused and commented code 
> no changes in functionality

Line wrap at 74 characters.  Add a period to the end of the sentence.

> 
> Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
> ---
> v3:
>  - regenrated patch from the clean tree
>  - removed unwanted addition
> v2:
>  - accidently added the functions in the {} blocks
> v1:
>  - some commented code wasnt deleted.
> Note:
> * This patch is part of the GSoC2026 application process for device tree bindings conversions
> * https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings
> 
>  drivers/staging/rtl8723bs/hal/sdio_halinit.c | 21 ++++++--------------
>  1 file changed, 6 insertions(+), 15 deletions(-)

It should only be deletions and 0 insertions.  Review the patch
and run checkpatch.pl on it before sending.

regards,
dan carpenter


  reply	other threads:[~2026-03-18 11:18 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-18  2:10 [PATCH] staging: rtl8723bs: fixed the trailing whitespaces/commented code Aadarsh Mandal
2026-03-18  6:52 ` Luka Gejak
2026-03-18  9:26   ` [PATCH] [PATCH] staging: rtl8723bs: clean up coding style in sdio_halinit.c V2 Aadarsh Mandal
2026-03-18  9:45     ` Luka Gejak
2026-03-18  9:53       ` Dan Carpenter
2026-03-18 10:43     ` [PATCH v3] staging: rtl8723bs: remove dead code Aadarsh Mandal
2026-03-18 11:17       ` Dan Carpenter [this message]
2026-03-18 11:33         ` Dan Carpenter
2026-03-18 11:37       ` Greg KH
2026-03-18  6:59 ` [PATCH] staging: rtl8723bs: fixed the trailing whitespaces/commented code Luka Gejak
2026-03-18 10:11   ` Greg KH
     [not found]     ` <CANQQrNO0GzqhYLj7DauWAoO=tVCz=86YaSjWWjAf-ER+UKmK6Q@mail.gmail.com>
2026-03-18 15:11       ` Greg KH
2026-03-18 17:54         ` Ethan Tidmore
2026-03-18 18:17           ` Greg KH
2026-03-18 21:06             ` Luka Gejak
2026-03-19  6:38               ` Greg KH
2026-03-19 14:11   ` [PATCH v4] staging: rtl8723bs: removed dead code Aadarsh Mandal
2026-03-20 14:46     ` [PATCH v5] staging: rtl8723bs: cleaned up patch formatting Aadarsh Mandal
2026-03-20 15:12       ` Luka Gejak
2026-03-19 14:12   ` [PATCH v4] staging: rtl8723bs: removed dead code Aadarsh Mandal
2026-03-19 14:18   ` Aadarsh Mandal
2026-03-19 17:46     ` Luka Gejak
2026-03-19 18:25     ` Ethan Tidmore
2026-03-19 18:26       ` Ethan Tidmore
2026-03-22 11:48 ` [PATCH v6] staging: rtl8723bs: remove commented-out code Aadarsh Mandal
2026-03-22 22:01   ` Ethan Tidmore
2026-03-23  8:47     ` Dan Carpenter
2026-03-24  4:07 ` [PATCH v7] " Aadarsh Mandal
2026-03-24  5:31   ` Luka Gejak
2026-03-24  6:54   ` Dan Carpenter
2026-03-24  8:12     ` Luka Gejak
2026-03-24  8:53       ` Dan Carpenter
     [not found]       ` <CANQQrNMNRuFw29zhckRYJ37Xf0YDXqZg9jnHgXznvNL=VfS7kA@mail.gmail.com>
2026-03-25  5:37         ` Luka Gejak
2026-03-28  3:31 ` [PATCH v8] " Aadarsh Mandal
2026-03-28 15:17   ` Luka Gejak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abqJ5kdM_OsgJohA@stanley.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=aadarshmandal9354@gmail.com \
    --cc=ethantidmore06@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=luka.gejak@linux.dev \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox