From: Dan Carpenter <dan.carpenter@linaro.org>
To: Gabriel Rondon <grondon@gmail.com>
Cc: vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org,
elder@kernel.org, gregkh@linuxfoundation.org,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: audio: use sysfs_emit() in show functions
Date: Thu, 19 Mar 2026 18:49:27 +0300 [thread overview]
Message-ID: <abwbB3KGkkTh4bYU@stanley.mountain> (raw)
In-Reply-To: <20260319120201.25210-1-grondon@gmail.com>
Doesn't apply for me.
On Thu, Mar 19, 2026 at 12:02:01PM +0000, Gabriel Rondon wrote:
> Replace sprintf() with sysfs_emit() in all sysfs attribute show
> functions. sysfs_emit() is aware of the sysfs buffer page size limit
> and should be used instead of sprintf() for sysfs show callbacks to
> prevent potential buffer overflows.
Please clearly state that there are no buffer overflows in the current
code.
>
> Also add the missing trailing newline to each output, which is the
> standard convention for sysfs attributes.
>
This changes the user space API so it could potentially break
a script.
regards,
dan carpenter
next prev parent reply other threads:[~2026-03-19 15:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 12:02 [PATCH] staging: greybus: audio: use sysfs_emit() in show functions Gabriel Rondon
2026-03-19 15:49 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-02-23 16:16 [PATCH] staging: greybus: audio: Use sysfs_emit " Shubham Chakraborty
2026-02-23 16:32 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abwbB3KGkkTh4bYU@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=grondon@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mgreer@animalcreek.com \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox