From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Fabio Aiuto <fabioaiuto83@gmail.com>,
Hans de Goede <hdegoede@redhat.com>,
linux-staging <linux-staging@lists.linux.dev>
Subject: Re: [PATCH 2/2] staging: rtl8723bs: core: eliminate erroneous reporting of unused variable 'evt_seq'
Date: Fri, 14 May 2021 09:02:53 +0800 [thread overview]
Message-ID: <ac2b2be3-3b1a-ce0f-0d9d-b6da533bf091@huawei.com> (raw)
In-Reply-To: <YJ1sSnEa+qFBOsli@kroah.com>
On 2021/5/14 2:13, Greg Kroah-Hartman wrote:
> On Thu, May 13, 2021 at 05:40:07PM +0800, Zhen Lei wrote:
>> GCC reports the following warning with W=1:
>>
>> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:6003:15: warning:
>> variable ‘evt_seq’ set but not used [-Wunused-but-set-variable]
>> 6030 | u8 evt_code, evt_seq;
>> | ^~~~~~~
>>
>> The local variable ‘evt_seq’ is referenced only when the macro
>> CHECK_EVENT_SEQ is defined, move its definition and assignment into the
>> control scope of macro CHECK_EVENT_SEQ, to fix the warning.
>>
>> By the way, clear local coding style warnings and delete several redundant
>> blank lines.
>
> Do not do lots of different things in the same patch, this should be
> broken up into doing "one logical thing per change".
>
> Please fix up and send as a series.
OK, I will split it into two patches.
>
> thanks,
>
> greg k-h
>
> .
>
prev parent reply other threads:[~2021-05-14 1:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 9:40 [PATCH 0/2] Clear several unused local variable warnings Zhen Lei
2021-05-13 9:40 ` [PATCH 1/2] staging: rtl8723bs: core: remove three unused local variables Zhen Lei
2021-05-13 18:14 ` Greg Kroah-Hartman
2021-05-14 1:04 ` Leizhen (ThunderTown)
2021-05-13 9:40 ` [PATCH 2/2] staging: rtl8723bs: core: eliminate erroneous reporting of unused variable 'evt_seq' Zhen Lei
2021-05-13 18:13 ` Greg Kroah-Hartman
2021-05-14 1:02 ` Leizhen (ThunderTown) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac2b2be3-3b1a-ce0f-0d9d-b6da533bf091@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox