From: "Nuno Sá" <noname.nuno@gmail.com>
To: Jonathan Cameron <jonathan.cameron@huawei.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Shi Hao <i.shihao.999@gmail.com>,
Michael.Hennerich@analog.com, lars@metafoo.de,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: iio: adt7316: replace sprintf() with sysfs_emit()
Date: Tue, 02 Dec 2025 13:55:39 +0000 [thread overview]
Message-ID: <ac51767a823e71a4779beee246c50deb30b57db8.camel@gmail.com> (raw)
In-Reply-To: <20251119145751.00003a9c@huawei.com>
On Wed, 2025-11-19 at 14:57 +0000, Jonathan Cameron wrote:
> On Tue, 18 Nov 2025 14:10:25 +0200
> Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>
> > On Tue, Nov 18, 2025 at 10:17 AM Nuno Sá <noname.nuno@gmail.com> wrote:
> > > On Sun, 2025-11-16 at 15:28 +0000, Jonathan Cameron wrote:
> > > > On Sun, 16 Nov 2025 13:08:07 +0200
> > > > Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> >
> > ...
> >
> > > > Applied, but I will note that this driver is a long way from suitable
> > > > for moving out of staging and I would be surprised if more than
> > > > one or two of the lines changed in this patch make it through the
> > > > necessary refactors (should anyone actually have another go at
> > > > doing them). Anyhow, I still think this is worth taking just to
> > > > reduce the noise of remaining instances of this.
> > > >
> > > > I'd have deleted this long ago except I actually have one somewhere
> > > > and it one of the supported parts was still listed as suitable for
> > > > new designs when I checked not long ago.
> > >
> > > Seems to be now "just" in production. So no longer advised for new designs. I gave a
> > > quick look and this is far from being a simple driver. It would require a fair amount
> > > of work to bring it out of staging. So, are there users relying on staging drivers?
> >
> > If there is no choice, yes. For example FBTFT is famous for being used
> > by IoT / DIY _a lot_. Currently a bit less since we got tinyDRM
> > subsystem with most popular drivers reimplemented there.
> >
> > > But I would assume that for staging we are still free to drop support it?
> >
> > At any level, we are still free to drop :-) Just different conditions
> > applied. For staging is basically an "effective immediately" case.
> >
>
> If no one replies to this thread in next few weeks to say otherwise, let us see
> if anyone objects to patches. I'll spin a series in a few weeks and they can sit
> in linux-next for most of the cycle to see anyone notices. It is easy to bring
> drivers back if turns out anyone cares and then there is some motivation to
> finally clean them up.
>
> staging/iio/
> accel/adis16203 is production
> adc/ad7816 is production (7817, 7818) - the 7816 itself is obsolete.
> addac/adt7316 is production (what we are discussing here)
I checked internally and we still have customers actually buying some of the chips supported by the
above driver. Not sure if it is being used with linux though... And more importantly, I cannot also
commit that someone will jump in to clean it up.
- Nuno Sá
prev parent reply other threads:[~2025-12-02 13:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-16 10:16 [PATCH] staging: iio: adt7316: replace sprintf() with sysfs_emit() Shi Hao
2025-11-16 11:08 ` Andy Shevchenko
2025-11-16 15:28 ` Jonathan Cameron
2025-11-18 8:18 ` Nuno Sá
2025-11-18 12:10 ` Andy Shevchenko
2025-11-19 14:57 ` Jonathan Cameron
2025-12-01 16:51 ` Marcelo Schmitt
2025-12-02 13:55 ` Nuno Sá [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac51767a823e71a4779beee246c50deb30b57db8.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=i.shihao.999@gmail.com \
--cc=jic23@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).