From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: hansg@kernel.org, mchehab@kernel.org, andy@kernel.org,
gregkh@linuxfoundation.org, sakari.ailus@linux.intel.com,
grondon@gmail.com, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: atomisp: fix alignment in function signature
Date: Thu, 2 Apr 2026 16:03:55 +0300 [thread overview]
Message-ID: <ac5pOwTLZHFtgyfG@ashevche-desk.local> (raw)
In-Reply-To: <CALoEA-zg2pFEvGGesXJPVfEJQCKZA0Cj5-oqS=U8GUKBd-TRkw@mail.gmail.com>
On Thu, Apr 02, 2026 at 02:56:08PM +0200, Joshua Crofts wrote:
> On Thu, 2 Apr 2026 at 14:50, Andy Shevchenko
> <andriy.shevchenko@intel.com> wrote:
> > First of all, missing period at the end.
> > Second, why? Does it fix anything?
> > Third, is this the only issue with the driver of a kind?
> >
> Hi, I was doing some checkpatch.pl work and got a few check errors.
> Wasn't sure if it's convention to group all check errors together or do each
> separately. Apologies for the misleading commit name, i'm aware it's cleanup
> and not a fix.
It is okay and good to group the fixes for the same driver of the same kind.
I don't believe it's the only single problem of this kind in this driver.
But you may double check and fix them all.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-02 13:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 9:18 [PATCH] staging: atomisp: fix alignment in function signature Joshua Crofts
2026-04-02 12:50 ` Andy Shevchenko
2026-04-02 12:56 ` Joshua Crofts
2026-04-02 13:03 ` Andy Shevchenko [this message]
2026-04-02 14:16 ` Joshua Crofts
2026-04-03 20:21 ` [PATCH v2] staging: atomisp: cleanup parenthesis alignment in pci Joshua Crofts
2026-04-04 19:48 ` Andy Shevchenko
2026-04-05 14:39 ` [PATCH v3] staging: media: " Joshua Crofts
2026-04-06 19:41 ` Andy Shevchenko
2026-04-07 6:32 ` Joshua Crofts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac5pOwTLZHFtgyfG@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=grondon@gmail.com \
--cc=hansg@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox