From: Dan Carpenter <error27@gmail.com>
To: Ayush Mukkanwar <ayushmukkanwar@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] staging: octeon: replace pr_* with dev_* and netdev_*
Date: Thu, 2 Apr 2026 16:17:18 +0300 [thread overview]
Message-ID: <ac5sXpd6lqnyoWlX@stanley.mountain> (raw)
In-Reply-To: <20260402114242.57411-1-ayushmukkanwar@gmail.com>
Last week I spent some time reviewing how bugs are introduced in staging
and the number one cause is complicated changes from the maintainers.
It's hard to avoid that because the kernel is complicated and complicated
things are hard.
But another major cause of bugs was pr_warn() to dev_warn() transitions.
I'm not sure what to do about that either really...
Anyway, I'm glad I don't have to review this patch until v4.
regards,
dan carpenter
prev parent reply other threads:[~2026-04-02 13:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 11:42 [PATCH v3 0/2] staging: octeon: replace pr_* with dev_* and netdev_* Ayush Mukkanwar
2026-04-02 11:42 ` [PATCH v3 1/2] staging: octeon: ethernet-spi: replace pr_err with dev_err Ayush Mukkanwar
2026-04-02 11:42 ` [PATCH v3 2/2] staging: octeon: ethernet: replace pr_* with dev_* and netdev_* Ayush Mukkanwar
2026-04-02 11:50 ` [PATCH v3 0/2] staging: octeon: " Greg KH
2026-04-02 13:17 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac5sXpd6lqnyoWlX@stanley.mountain \
--to=error27@gmail.com \
--cc=ayushmukkanwar@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox