From: Dan Carpenter <error27@gmail.com>
To: Andrei Khomenkov <khomenkov@mailbox.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Luka Gejak <luka.gejak@linux.dev>,
Ethan Tidmore <ethantidmore06@gmail.com>,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v3 1/6] staging: rtl8723bs: core: simplify boolean comparisons
Date: Thu, 2 Apr 2026 19:41:12 +0300 [thread overview]
Message-ID: <ac6cKPY4MsKKRqH-@stanley.mountain> (raw)
In-Reply-To: <20260402150429.14761-2-khomenkov@mailbox.org>
On Thu, Apr 02, 2026 at 06:04:24PM +0300, Andrei Khomenkov wrote:
> Simplify boolean comparisons to improve readability and conform
> to the Linux kernel coding style.
>
> Signed-off-by: Andrei Khomenkov <khomenkov@mailbox.org>
> ---
What changed since v2?
> drivers/staging/rtl8723bs/core/rtw_ap.c | 2 +-
> drivers/staging/rtl8723bs/core/rtw_btcoex.c | 2 +-
[ snip ]
> @@ -1950,8 +1950,8 @@ static int recv_indicatepkts_in_order(struct adapter *padapter, struct recv_reor
>
> /* indicate this recv_frame */
> if (!pattrib->amsdu) {
> - if ((padapter->bDriverStopped == false) &&
> - (padapter->bSurpriseRemoved == false))
> + if (!(padapter->bDriverStopped) &&
> + !(padapter->bSurpriseRemoved))
Too many parens. Other places have this issue too.
regards,
dan carpenter
next prev parent reply other threads:[~2026-04-02 16:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 15:04 [PATCH v3 0/6] staging: rtl8723bs: cleanup code and style Andrei Khomenkov
2026-04-02 15:04 ` [PATCH v3 1/6] staging: rtl8723bs: core: simplify boolean comparisons Andrei Khomenkov
2026-04-02 16:41 ` Dan Carpenter [this message]
2026-04-02 15:04 ` [PATCH v3 2/6] staging: rtl8723bs: hal: " Andrei Khomenkov
2026-04-02 15:04 ` [PATCH v3 3/6] staging: rtl8723bs: os_dep: " Andrei Khomenkov
2026-04-02 15:04 ` [PATCH v3 4/6] staging: rtl8723bs: core: style cleanup Andrei Khomenkov
2026-04-02 15:04 ` [PATCH v3 5/6] staging: rtl8723bs: hal: " Andrei Khomenkov
2026-04-02 16:46 ` Dan Carpenter
2026-04-02 15:04 ` [PATCH v3 6/6] staging: rtl8723bs: os_dep: " Andrei Khomenkov
2026-04-02 21:43 ` [PATCH v3 0/6] staging: rtl8723bs: cleanup code and style Ethan Tidmore
2026-04-03 6:40 ` Greg Kroah-Hartman
2026-04-03 7:14 ` Ethan Tidmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac6cKPY4MsKKRqH-@stanley.mountain \
--to=error27@gmail.com \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=khomenkov@mailbox.org \
--cc=linux-staging@lists.linux.dev \
--cc=luka.gejak@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox