From: Dan Carpenter <error27@gmail.com>
To: Andrei Khomenkov <khomenkov@mailbox.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Luka Gejak <luka.gejak@linux.dev>,
Ethan Tidmore <ethantidmore06@gmail.com>,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v3 5/6] staging: rtl8723bs: hal: style cleanup
Date: Thu, 2 Apr 2026 19:46:06 +0300 [thread overview]
Message-ID: <ac6dTuXc-tVunC8f@stanley.mountain> (raw)
In-Reply-To: <20260402150429.14761-6-khomenkov@mailbox.org>
On Thu, Apr 02, 2026 at 06:04:28PM +0300, Andrei Khomenkov wrote:
> Cleanup coding style errors in the lines modified by the
> previous logic changes. This includes removing extra
> parentheses, fixing line wrapping for if-conditions, and
> adding spaces around bitwise operators.
Two things.
1) Generally, we don't like when people introduce a problem and
then fix it later in the patchset. There can be exceptions
where this makes reviewing the code easier, but I'm not sure
they apply here.
2) This patch does many too things at once.
regards,
dan carpenter
next prev parent reply other threads:[~2026-04-02 16:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 15:04 [PATCH v3 0/6] staging: rtl8723bs: cleanup code and style Andrei Khomenkov
2026-04-02 15:04 ` [PATCH v3 1/6] staging: rtl8723bs: core: simplify boolean comparisons Andrei Khomenkov
2026-04-02 16:41 ` Dan Carpenter
2026-04-02 15:04 ` [PATCH v3 2/6] staging: rtl8723bs: hal: " Andrei Khomenkov
2026-04-02 15:04 ` [PATCH v3 3/6] staging: rtl8723bs: os_dep: " Andrei Khomenkov
2026-04-02 15:04 ` [PATCH v3 4/6] staging: rtl8723bs: core: style cleanup Andrei Khomenkov
2026-04-02 15:04 ` [PATCH v3 5/6] staging: rtl8723bs: hal: " Andrei Khomenkov
2026-04-02 16:46 ` Dan Carpenter [this message]
2026-04-02 15:04 ` [PATCH v3 6/6] staging: rtl8723bs: os_dep: " Andrei Khomenkov
2026-04-02 21:43 ` [PATCH v3 0/6] staging: rtl8723bs: cleanup code and style Ethan Tidmore
2026-04-03 6:40 ` Greg Kroah-Hartman
2026-04-03 7:14 ` Ethan Tidmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac6dTuXc-tVunC8f@stanley.mountain \
--to=error27@gmail.com \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=khomenkov@mailbox.org \
--cc=linux-staging@lists.linux.dev \
--cc=luka.gejak@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox