From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Prithvi Tambewagh <activprithvi@gmail.com>
Cc: gregkh@linuxfoundation.org, abrahamadekunle50@gmail.com,
straube.linux@gmail.com, b9788213@gmail.com,
ethantidmore06@gmail.com, dan.carpenter@linaro.org,
weibu@redadmin.org, knavaneeth786@gmail.com,
ignacio.pena87@gmail.com, dharanitharan725@gmail.com,
lukagejak5@gmail.com, samasth.norway.ananda@oracle.com,
karanja99erick@gmail.com, s9430939@naver.com,
suunj1331@gmail.com, ysinghcin@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org,
david.hunter.linux@gmail.com, khalid@kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: fix constant on left side of test checkpatch warnings
Date: Mon, 23 Mar 2026 18:42:49 +0200 [thread overview]
Message-ID: <acFtiaXTp7bwl604@ashevche-desk.local> (raw)
In-Reply-To: <20260323162901.121947-1-activprithvi@gmail.com>
On Mon, Mar 23, 2026 at 09:59:01PM +0530, Prithvi Tambewagh wrote:
> In all types of comparison/test (using ==, !=, >=, <=, >, <
> operators) ensure that the constant lies to the right side of the test,
> thus fixing checkpatch warnings : comparisons should place the constant
> on the right side of the test, throughout the rtl8723bs driver.
...
> do {
> valid = rtw_read8(padapter, REG_HMETFR) & BIT(msgbox_num);
> - if (0 == valid) {
> + if (!valid)
> read_down = true;
> - }
> } while ((!read_down) && (retry_cnts--));
>
> return read_down;
This entire piece can be replaced with something from iopoll.h.
...
> - if (WIFI_CTRL_TYPE == GetFrameType(pframe))
> + if (GetFrameType(pframe) == WIFI_CTRL_TYPE)
> return true;
> else
> return false;
Just
return GetFrameType(pframe) == WIFI_CTRL_TYPE;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-23 16:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 16:29 [PATCH v2] staging: rtl8723bs: fix constant on left side of test checkpatch warnings Prithvi Tambewagh
2026-03-23 16:42 ` Andy Shevchenko [this message]
2026-03-24 13:02 ` Prithvi
2026-03-24 13:43 ` Andy Shevchenko
2026-03-24 13:55 ` Prithvi
2026-03-24 14:05 ` Andy Shevchenko
2026-03-24 16:02 ` Prithvi
2026-03-24 17:41 ` Shuah Khan
2026-03-25 7:22 ` Dan Carpenter
2026-03-25 17:57 ` Shuah Khan
2026-03-25 21:34 ` Dan Carpenter
2026-03-25 22:22 ` Shuah Khan
2026-03-28 17:47 ` Prithvi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acFtiaXTp7bwl604@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=abrahamadekunle50@gmail.com \
--cc=activprithvi@gmail.com \
--cc=b9788213@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=david.hunter.linux@gmail.com \
--cc=dharanitharan725@gmail.com \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ignacio.pena87@gmail.com \
--cc=karanja99erick@gmail.com \
--cc=khalid@kernel.org \
--cc=knavaneeth786@gmail.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lukagejak5@gmail.com \
--cc=s9430939@naver.com \
--cc=samasth.norway.ananda@oracle.com \
--cc=skhan@linuxfoundation.org \
--cc=straube.linux@gmail.com \
--cc=suunj1331@gmail.com \
--cc=weibu@redadmin.org \
--cc=ysinghcin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox