From: Johan Hovold <johan@kernel.org>
To: "Damien Riégel" <damien.riegel@silabs.com>
Cc: Alex Elder <elder@kernel.org>,
Dan Carpenter <dan.carpenter@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] greybus: raw: fix use-after-free if write is called after disconnect
Date: Tue, 24 Mar 2026 09:03:47 +0100 [thread overview]
Message-ID: <acJFY3-qJ4IZGe6m@hovoldconsulting.com> (raw)
In-Reply-To: <acJCrBYJS61o2ZbG@hovoldconsulting.com>
On Tue, Mar 24, 2026 at 08:52:12AM +0100, Johan Hovold wrote:
> On Mon, Mar 23, 2026 at 10:25:10PM -0400, Damien Riégel wrote:
> > + retval = gb_raw_send(raw, count, buf);
> > + if (!retval)
> > + retval = count;
>
> I'd invert this so that we test for errors consistently:
>
> if (retval)
> goto exit;
>
> retval = count;
>
> > +exit:
> > + up_read(&raw->disconnect_lock);
> > +
> > + return retval;
> > }
> >
> > static ssize_t raw_read(struct file *file, char __user *buf, size_t count,
Forgot to say you can include my:
Reviewed-by: Johan Hovold <johan@kernel.org>
when respinning.
Johan
next prev parent reply other threads:[~2026-03-24 8:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 2:25 [PATCH v3 1/2] greybus: raw: fix use-after-free on cdev close Damien Riégel
2026-03-24 2:25 ` [PATCH v3 2/2] greybus: raw: fix use-after-free if write is called after disconnect Damien Riégel
2026-03-24 7:52 ` Johan Hovold
2026-03-24 8:03 ` Johan Hovold [this message]
2026-03-24 7:45 ` [PATCH v3 1/2] greybus: raw: fix use-after-free on cdev close Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acJFY3-qJ4IZGe6m@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=damien.riegel@silabs.com \
--cc=dan.carpenter@linaro.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox