From: Dan Carpenter <dan.carpenter@linaro.org>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: Prithvi <activprithvi@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
gregkh@linuxfoundation.org, abrahamadekunle50@gmail.com,
straube.linux@gmail.com, b9788213@gmail.com,
ethantidmore06@gmail.com, weibu@redadmin.org,
knavaneeth786@gmail.com, ignacio.pena87@gmail.com,
dharanitharan725@gmail.com, lukagejak5@gmail.com,
samasth.norway.ananda@oracle.com, karanja99erick@gmail.com,
s9430939@naver.com, suunj1331@gmail.com, ysinghcin@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev,
david.hunter.linux@gmail.com, khalid@kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: fix constant on left side of test checkpatch warnings
Date: Wed, 25 Mar 2026 10:22:56 +0300 [thread overview]
Message-ID: <acONUF2nLAk6uhQs@stanley.mountain> (raw)
In-Reply-To: <656d3bf5-8d97-454e-9691-540cdb79dab4@linuxfoundation.org>
There are a couple of different things happening here. The mentorship
program has its own rules. The rule that people should test their code
seems like a good rule.
In staging, most of the patches that we apply not tested. I assumed
this patch wasn't tested. Patches like this are not a big deal because
we can easily review them. Sometimes, patches change runtime so unless
it's a security issue, we want those to be tested.
>
> - if (0x00 == PathAOK) {
> - }
>
We normally wouldn't merge patches which do multiple things at once
but it doesn't really make sense to reverse this condition around since
it's dead code so to me it falls under the "related change" category.
regards,
dan carpenter
next prev parent reply other threads:[~2026-03-25 7:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 16:29 [PATCH v2] staging: rtl8723bs: fix constant on left side of test checkpatch warnings Prithvi Tambewagh
2026-03-23 16:42 ` Andy Shevchenko
2026-03-24 13:02 ` Prithvi
2026-03-24 13:43 ` Andy Shevchenko
2026-03-24 13:55 ` Prithvi
2026-03-24 14:05 ` Andy Shevchenko
2026-03-24 16:02 ` Prithvi
2026-03-24 17:41 ` Shuah Khan
2026-03-25 7:22 ` Dan Carpenter [this message]
2026-03-25 17:57 ` Shuah Khan
2026-03-25 21:34 ` Dan Carpenter
2026-03-25 22:22 ` Shuah Khan
2026-03-28 17:47 ` Prithvi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acONUF2nLAk6uhQs@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=abrahamadekunle50@gmail.com \
--cc=activprithvi@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=b9788213@gmail.com \
--cc=david.hunter.linux@gmail.com \
--cc=dharanitharan725@gmail.com \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ignacio.pena87@gmail.com \
--cc=karanja99erick@gmail.com \
--cc=khalid@kernel.org \
--cc=knavaneeth786@gmail.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lukagejak5@gmail.com \
--cc=s9430939@naver.com \
--cc=samasth.norway.ananda@oracle.com \
--cc=skhan@linuxfoundation.org \
--cc=straube.linux@gmail.com \
--cc=suunj1331@gmail.com \
--cc=weibu@redadmin.org \
--cc=ysinghcin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox