From: Dan Carpenter <dan.carpenter@linaro.org>
To: Omer El Idrissi <omer.e.idrissi@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Omer El Idrissi <omer.e.idriss@gmail.com>
Subject: Re: [PATCH v3 0/4] clean up error handling
Date: Thu, 26 Mar 2026 11:39:22 +0300 [thread overview]
Message-ID: <acTwujeiZ5VnnZeM@stanley.mountain> (raw)
In-Reply-To: <20260326081627.5841-1-omer.e.idrissi@gmail.com>
Sorry, I'm going to ask that you send these one last time. It should
just be 2 patches. patch 1 stays the same, and patches 2, 3 and 4 get
squashed into the same patch.
The thing is that right now we're changing sdio_init() and then
cleaning up the callers. We should change it and clean up the callers
all in one go. One thing per patch means "One complete thing" not
"half a thing per patch". It makes it easier to review when it's done
in one go, because otherwise, when I'm reviewing patch 2, I have to
check all the callers anyway.
regards,
dan carpenter
next prev parent reply other threads:[~2026-03-26 8:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 22:04 [PATCH 0/2] rtl8723bs: clean up error handling Omer El Idrissi
2026-03-24 22:04 ` [PATCH 1/2] staging: rtl8723bs: use direct returns in sdio_dvobj_init() Omer El Idrissi
2026-03-24 22:04 ` [PATCH 2/2] staging: rtl8723bs: cleanup return in sdio_init() Omer El Idrissi
2026-03-25 7:36 ` Dan Carpenter
2026-03-25 18:51 ` Omer
2026-03-26 7:19 ` Dan Carpenter
2026-03-25 19:05 ` [PATCH v2 0/3] clean up error handling Omer El Idrissi
2026-03-25 19:05 ` [PATCH v2 1/3] staging: rtl8723bs: use direct returns in sdio_dvobj_init() Omer El Idrissi
2026-03-25 19:05 ` [PATCH v2 2/3] staging: rtl8723bs: cleanup return in sdio_init() Omer El Idrissi
2026-03-25 19:06 ` [PATCH v2 3/3] staging: rtl8723bs: clean up callees for sdio_init function Omer El Idrissi
2026-03-26 8:16 ` [PATCH v3 0/4] clean up error handling Omer El Idrissi
2026-03-26 8:16 ` [PATCH v3 1/4] staging: rtl8723bs: use direct returns in sdio_dvobj_init() Omer El Idrissi
2026-03-26 8:16 ` [PATCH v3 2/4] staging: rtl8723bs: cleanup return in sdio_init() Omer El Idrissi
2026-03-26 8:16 ` [PATCH v3 3/4] staging: rtl8723bs: clean up callees for sdio_init function Omer El Idrissi
2026-03-26 8:16 ` [PATCH v3 4/4] staging: rtl8723bs: Choose slightly more readable error check Omer El Idrissi
2026-03-26 8:39 ` Dan Carpenter [this message]
2026-03-26 10:36 ` [PATCH v3 0/4] clean up error handling Greg KH
2026-03-26 11:10 ` Omer
2026-03-26 14:49 ` Greg KH
2026-03-26 8:18 ` Omer El Idrissi
2026-03-26 8:18 ` [PATCH v3 1/4] staging: rtl8723bs: use direct returns in sdio_dvobj_init() Omer El Idrissi
2026-03-26 8:18 ` [PATCH v3 2/4] staging: rtl8723bs: cleanup return in sdio_init() Omer El Idrissi
2026-03-26 8:18 ` [PATCH v3 3/4] staging: rtl8723bs: clean up callees for sdio_init function Omer El Idrissi
2026-03-26 8:18 ` [PATCH v3 4/4] staging: rtl8723bs: Choose slightly more readable error check Omer El Idrissi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acTwujeiZ5VnnZeM@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=omer.e.idriss@gmail.com \
--cc=omer.e.idrissi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox