From: Dan Carpenter <dan.carpenter@linaro.org>
To: Omer El Idrissi <omer.e.idrissi@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/2] clean up error handling
Date: Thu, 26 Mar 2026 12:59:39 +0300 [thread overview]
Message-ID: <acUDi8Mi7pw3KNBB@stanley.mountain> (raw)
In-Reply-To: <20260326093607.13011-1-omer.e.idrissi@gmail.com>
On Thu, Mar 26, 2026 at 10:36:05AM +0100, Omer El Idrissi wrote:
> This series lets sdio_init() propagate standard kernel error codes
> instead of returning _SUCCESS/_FAIL. There are two callers for this
> function. rtw_resume_process_normal() already returns negative values
> but the caller doesn't check for errors so changing this doesn't
> affect anything. sdio_dvobj_init() returns NULL on
> error so leave that as-is.
>
> Signed-off-by: Omer El Idrissi <omer.e.idrissi@gmail.com>
> ---
Great! Thanks.
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
regards,
dan carpenter
prev parent reply other threads:[~2026-03-26 9:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 9:36 [PATCH v4 0/2] clean up error handling Omer El Idrissi
2026-03-26 9:36 ` [PATCH v4 1/2] staging: rtl8723bs: use direct returns in sdio_dvobj_init() Omer El Idrissi
2026-03-26 9:36 ` [PATCH v4 2/2] staging: rtl8723bs: cleanup return in sdio_init() Omer El Idrissi
2026-03-26 9:59 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acUDi8Mi7pw3KNBB@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=omer.e.idrissi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox