[PATCH] staging: rtl8723bs: remove spaces before tabs in hal_com.c

[PATCH] staging: rtl8723bs: remove spaces before tabs in hal_com.c

[MrXploisLite]

Fix checkpatch warning 'please, no space before tabs' in comment blocks.
This change removes spaces that precede tab characters in three comment
lines within the _TwoOutPipeMapping and _ThreeOutPipeMapping functions.

No functional change, only whitespace cleanup to comply with kernel
coding style.

Signed-off-by: MrXploisLite <arokigaming@gmail.com>
---
 drivers/staging/rtl8723bs/hal/hal_com.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
index 1298ab2e5..b045bad4c 100644
--- a/drivers/staging/rtl8723bs/hal/hal_com.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com.c
@@ -359,7 +359,7 @@ static void _TwoOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
 
 	if (bWIFICfg) { /* WMM */
 
-		/* 	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
+		/*	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
 		/*   0,		1,	0,	1,	0,	0,	0,	0,		0	}; */
 		/* 0:ep_0 num, 1:ep_1 num */
 
@@ -400,7 +400,7 @@ static void _ThreeOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
 
 	if (bWIFICfg) { /* for WMM */
 
-		/* 	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
+		/*	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
 		/*   1,		2,	1,	0,	0,	0,	0,	0,		0	}; */
 		/* 0:H, 1:N, 2:L */
 
@@ -417,7 +417,7 @@ static void _ThreeOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
 	} else { /* typical setting */
 
 
-		/* 	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
+		/*	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
 		/*   2,		2,	1,	0,	0,	0,	0,	0,		0	}; */
 		/* 0:H, 1:N, 2:L */
 
-- 
2.53.0

Re: [PATCH] staging: rtl8723bs: remove spaces before tabs in hal_com.c

[Ethan Tidmore]

On Wed Mar 25, 2026 at 6:55 PM CDT, MrXploisLite wrote:
> Fix checkpatch warning 'please, no space before tabs' in comment blocks.
> This change removes spaces that precede tab characters in three comment
> lines within the _TwoOutPipeMapping and _ThreeOutPipeMapping functions.
>
> No functional change, only whitespace cleanup to comply with kernel
> coding style.
>
> Signed-off-by: MrXploisLite <arokigaming@gmail.com>
> ---

I believe this has been NACKed in the past. This is just changing
whitespace in a comment, it doesn't really "improve" anything.

Thanks,

ET

Re: [PATCH] staging: rtl8723bs: remove spaces before tabs in hal_com.c

[Dan Carpenter]

On Thu, Mar 26, 2026 at 01:13:25PM -0500, Ethan Tidmore wrote:
> On Wed Mar 25, 2026 at 6:55 PM CDT, MrXploisLite wrote:
> > Fix checkpatch warning 'please, no space before tabs' in comment blocks.
> > This change removes spaces that precede tab characters in three comment
> > lines within the _TwoOutPipeMapping and _ThreeOutPipeMapping functions.
> >
> > No functional change, only whitespace cleanup to comply with kernel
> > coding style.
> >
> > Signed-off-by: MrXploisLite <arokigaming@gmail.com>
> > ---
> 
> I believe this has been NACKed in the past. This is just changing
> whitespace in a comment, it doesn't really "improve" anything.
> 

Huh.  I can't believe you remember conversations from 2 months ago.  I
had to look it up.  I did NAK this patch, but the reason for that is
the the alignment is wrong before and after the patch.  It should be
something like:

		/*   BK,   BE,   VI,   VO,  BCN,  CMD,  MGT, HIGH, HCCA */
		/*    0,    1,    0,    1,    0,    0,    0,    0,    0 */
		/* 0:ep_0 num, 1:ep_1 num */

So the HCCA column header is over the last zero.

Although, looking at it now, we could just delete the comment.  I think
it was copy and pasted in during development so the author didn't have to
switch windows back and forth when they were implementing the code.  I
don't think it was supposed to be in the released code since it doesn't
add any new information.

pdvobjpriv->Queue2Pipe[0] = pdvobjpriv->RtOutPipe[1];/* VO */
The 1 here matches the VO column.                 ^     ^^

Check that everything is implemented correctly and then just delete
these comments.

regards,
dan carpenter