From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Anushka Badhe <anushkabadhe@gmail.com>
Cc: andy@kernel.org, gregkh@linuxfoundation.org, hansg@kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev, mchehab@kernel.org,
sakari.ailus@linux.intel.com
Subject: Re: [PATCH v6] staging: media: atomisp: fix GP_TIMER_BASE scope in gp_timer.c
Date: Fri, 27 Mar 2026 11:43:33 +0200 [thread overview]
Message-ID: <acZRRXXBoflHV0rt@ashevche-desk.local> (raw)
In-Reply-To: <20260327031106.10386-1-anushkabadhe@gmail.com>
On Fri, Mar 27, 2026 at 08:41:06AM +0530, Anushka Badhe wrote:
> GP_TIMER_BASE is only used in gp_timer.c and it does not need to be
> globally visible.
>
> Move its declaration from system_local.c to gp_timer.c and make it file
> local by marking it static. Remove external declaration from system_local.h
> and its usage in gp_timer.h
>
> This fixes a sparse warning about global visibility and cleans up
> unnecessary global exposure.
...
> ---
> Changes in v6:
> - Mark scope of GP_TIMER_BASE static
Good catch, but read my comment against v5. And slow down with new versions,
no new version within 24h, please!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-27 9:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 3:11 [PATCH v6] staging: media: atomisp: fix GP_TIMER_BASE scope in gp_timer.c Anushka Badhe
2026-03-27 9:43 ` Andy Shevchenko [this message]
2026-03-30 1:19 ` Anushka B
2026-03-30 8:47 ` Andy Shevchenko
2026-03-27 11:24 ` Sakari Ailus
2026-03-30 1:32 ` Anushka B
2026-04-01 6:55 ` Sakari Ailus
2026-04-01 16:02 ` Anushka B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acZRRXXBoflHV0rt@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=anushkabadhe@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox