From: Dan Carpenter <error27@gmail.com>
To: Shivam Gupta <shivgupta751157@gmail.com>
Cc: gregkh@linuxfoundation.org, johan@kernel.org, elder@kernel.org,
vaibhav.sr@gmail.com, mgreer@animalcreek.com,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: audio_manager: Add missing newline to sysfs_emit outputs
Date: Mon, 30 Mar 2026 12:35:07 +0300 [thread overview]
Message-ID: <aceO98aKU9Yc_OHt@stanley.mountain> (raw)
In-Reply-To: <20260328044527.10489-1-shivgupta751157@gmail.com>
On Sat, Mar 28, 2026 at 10:15:27AM +0530, Shivam Gupta wrote:
> sysfs_emit outputs in audio_manager_module.c do not include a terminating
> newline, which is required for proper sysfs formatting.
>
> Add newline characters to all sysfs_emit format strings.
>
> Signed-off-by: Shivam Gupta <shivgupta751157@gmail.com>
> ---
"Proper sysfs format" is all well and good, but this is something which
already exists and adding a newline is changing the API. If you were a
maintainer of this code, then I would have more confidence that you know
all the user space code which uses this API and are able to test it
thouroughly.
We merged a similar change recently and, whatever, that's fine, probably
it doesn't break anything. But the more we do it, the more likely we
are to break something so my instinct is that we should discourage this
kind of change.
regards,
dan carpenter
prev parent reply other threads:[~2026-03-30 9:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-28 4:45 [PATCH] staging: greybus: audio_manager: Add missing newline to sysfs_emit outputs Shivam Gupta
2026-03-28 6:02 ` Greg KH
2026-03-28 14:51 ` Hadi Chokr
2026-03-30 9:35 ` Dan Carpenter
2026-03-30 9:35 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aceO98aKU9Yc_OHt@stanley.mountain \
--to=error27@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mgreer@animalcreek.com \
--cc=shivgupta751157@gmail.com \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox