From: Dan Carpenter <error27@gmail.com>
To: Mashiro Chen <mashiro.chen@mailbox.org>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] staging: rtl8723bs: fix logic bug in WRITEEF4BYTE macro
Date: Mon, 30 Mar 2026 12:35:13 +0300 [thread overview]
Message-ID: <acl-tVy1PJX3XBuR@stanley.mountain> (raw)
In-Reply-To: <20260328142709.330401-2-mashiro.chen@mailbox.org>
On Sat, Mar 28, 2026 at 10:27:06PM +0800, Mashiro Chen wrote:
> The WRITEEF4BYTE macro incorrectly used EF2BYTE for
> 4-byte memory writes. Fix it to use EF4BYTE instead.
>
> Signed-off-by: Mashiro Chen <mashiro.chen@mailbox.org>
> ---
> drivers/staging/rtl8723bs/include/basic_types.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/include/basic_types.h b/drivers/staging/rtl8723bs/include/basic_types.h
> index 8adb95f9f..99b12c724 100644
> --- a/drivers/staging/rtl8723bs/include/basic_types.h
> +++ b/drivers/staging/rtl8723bs/include/basic_types.h
> @@ -64,7 +64,7 @@
>
> #define WRITEEF4BYTE(_ptr, _val) \
This macro is never used so just delete it instead.
regards,
dan carpenter
> do { \
> - (*((u32 *)(_ptr))) = EF2BYTE(_val); \
> + (*((u32 *)(_ptr))) = EF4BYTE(_val); \
> } while (0)
>
> /*
> --
> 2.53.0
>
next prev parent reply other threads:[~2026-03-30 9:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-28 14:27 [PATCH 0/4] staging: rtl8723bs: macro fixes in basic_types.h Mashiro Chen
2026-03-28 14:27 ` [PATCH 1/4] staging: rtl8723bs: fix logic bug in WRITEEF4BYTE macro Mashiro Chen
2026-03-30 9:35 ` Dan Carpenter [this message]
2026-03-30 11:32 ` Mashiro Chen
2026-03-28 14:27 ` [PATCH 2/4] staging: rtl8723bs: wrap complex macros with parentheses Mashiro Chen
2026-03-28 14:27 ` [PATCH 3/4] staging: rtl8723bs: remove unnecessary do-while for macros Mashiro Chen
2026-03-28 14:27 ` [PATCH 4/4] staging: rtl8723bs: remove redundant blank lines in basic_types.h Mashiro Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acl-tVy1PJX3XBuR@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mashiro.chen@mailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox