From: Johan Hovold <johan@kernel.org>
To: Haoyu Lu <hechushiguitu666@gmail.com>
Cc: Vaibhav Agarwal <vaibhav.sr@gmail.com>,
Mark Greer <mgreer@animalcreek.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alex Elder <elder@kernel.org>,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: audio: fix error message for BTN_3 button
Date: Mon, 30 Mar 2026 09:58:15 +0200 [thread overview]
Message-ID: <acotF6BuMHzno-XJ@hovoldconsulting.com> (raw)
In-Reply-To: <20260330062402.1454-1-hechushiguitu666@gmail.com>
On Mon, Mar 30, 2026 at 02:24:02PM +0800, Haoyu Lu wrote:
> In gbaudio_init_jack(), when setting SND_JACK_BTN_3 key, the error message
> incorrectly says "Failed to set BTN_0". This should be "Failed to set BTN_3"
> to match the button being configured.
Please wrap your commit messages at 72 columns or so (checkpatch warns).
> Signed-off-by: Haoyu Lu <hechushiguitu666@gmail.com>
Looks correct otherwise, so you can add my
Reviewed-by: Johan Hovold <johan@kernel.org>
when resending.
Johan
prev parent reply other threads:[~2026-03-30 7:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 6:24 [PATCH] staging: greybus: audio: fix error message for BTN_3 button Haoyu Lu
2026-03-30 7:58 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acotF6BuMHzno-XJ@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=hechushiguitu666@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mgreer@animalcreek.com \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox