* [PATCH] staging: greybus: audio: fix error message for BTN_3 button
@ 2026-03-30 6:24 Haoyu Lu
2026-03-30 7:58 ` Johan Hovold
0 siblings, 1 reply; 2+ messages in thread
From: Haoyu Lu @ 2026-03-30 6:24 UTC (permalink / raw)
To: Vaibhav Agarwal, Mark Greer
Cc: Johan Hovold, Greg Kroah-Hartman, Alex Elder, greybus-dev,
linux-staging, linux-kernel, Haoyu Lu
In gbaudio_init_jack(), when setting SND_JACK_BTN_3 key, the error message
incorrectly says "Failed to set BTN_0". This should be "Failed to set BTN_3"
to match the button being configured.
Signed-off-by: Haoyu Lu <hechushiguitu666@gmail.com>
---
drivers/staging/greybus/audio_codec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
index 444c53b4e08d..720aa752e17e 100644
--- a/drivers/staging/greybus/audio_codec.c
+++ b/drivers/staging/greybus/audio_codec.c
@@ -781,7 +781,7 @@ static int gbaudio_init_jack(struct gbaudio_module_info *module,
ret = snd_jack_set_key(module->button.jack.jack, SND_JACK_BTN_3,
KEY_VOLUMEDOWN);
if (ret) {
- dev_err(module->dev, "Failed to set BTN_0\n");
+ dev_err(module->dev, "Failed to set BTN_3\n");
goto free_jacks;
}
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: greybus: audio: fix error message for BTN_3 button
2026-03-30 6:24 [PATCH] staging: greybus: audio: fix error message for BTN_3 button Haoyu Lu
@ 2026-03-30 7:58 ` Johan Hovold
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hovold @ 2026-03-30 7:58 UTC (permalink / raw)
To: Haoyu Lu
Cc: Vaibhav Agarwal, Mark Greer, Greg Kroah-Hartman, Alex Elder,
greybus-dev, linux-staging, linux-kernel
On Mon, Mar 30, 2026 at 02:24:02PM +0800, Haoyu Lu wrote:
> In gbaudio_init_jack(), when setting SND_JACK_BTN_3 key, the error message
> incorrectly says "Failed to set BTN_0". This should be "Failed to set BTN_3"
> to match the button being configured.
Please wrap your commit messages at 72 columns or so (checkpatch warns).
> Signed-off-by: Haoyu Lu <hechushiguitu666@gmail.com>
Looks correct otherwise, so you can add my
Reviewed-by: Johan Hovold <johan@kernel.org>
when resending.
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-30 7:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-30 6:24 [PATCH] staging: greybus: audio: fix error message for BTN_3 button Haoyu Lu
2026-03-30 7:58 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox