From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Md. Mahmudul Hasan Mabud" <mdmahmudulhasan1511@gmail.com>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
linux-iio@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/4] staging: iio: adc: ad7816: use modern IIO attribute macros
Date: Tue, 31 Mar 2026 12:10:44 +0300 [thread overview]
Message-ID: <acuPlI8kh7iyWPXt@ashevche-desk.local> (raw)
In-Reply-To: <20260331072453.6530-5-mdmahmudulhasan1511@gmail.com>
On Tue, Mar 31, 2026 at 01:24:53PM +0600, Md. Mahmudul Hasan Mabud wrote:
> Modernize the driver by using IIO_DEVICE_ATTR_RW and
> IIO_DEVICE_ATTR_RO macros. This involves renaming the callback
> functions to standard <name>_show and <name>_store formats, making
> the code cleaner and more maintainable.
Missed my comments about commit message changes and below about line lengths.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-03-31 9:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 7:24 [PATCH v4 0/4] staging: iio: adc: ad7816: code cleanups and modernization Md. Mahmudul Hasan Mabud
2026-03-31 7:24 ` [PATCH v4 1/4] staging: iio: adc: ad7816: redefine mode constants to start from 0 Md. Mahmudul Hasan Mabud
2026-03-31 7:24 ` [PATCH v4 2/4] staging: iio: adc: ad7816: use sysfs_match_string() for mode selection Md. Mahmudul Hasan Mabud
2026-03-31 7:24 ` [PATCH v4 3/4] staging: iio: adc: ad7816: replace sprintf() with sysfs_emit() Md. Mahmudul Hasan Mabud
2026-03-31 9:09 ` Andy Shevchenko
2026-03-31 7:24 ` [PATCH v4 4/4] staging: iio: adc: ad7816: use modern IIO attribute macros Md. Mahmudul Hasan Mabud
2026-03-31 9:10 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acuPlI8kh7iyWPXt@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mdmahmudulhasan1511@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox