From: Dan Carpenter <error27@gmail.com>
To: Andrei Khomenkov <khomenkov@mailbox.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Luka Gejak <luka.gejak@linux.dev>,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v2 1/2] staging: rtl8723bs: simplify boolean comparisons
Date: Wed, 1 Apr 2026 11:18:18 +0300 [thread overview]
Message-ID: <aczUykCMQVYbk5Ej@stanley.mountain> (raw)
In-Reply-To: <20260330184640.17795-2-khomenkov@mailbox.org>
On Mon, Mar 30, 2026 at 09:46:38PM +0300, Andrei Khomenkov wrote:
> @@ -1943,8 +1943,8 @@ static int recv_indicatepkts_in_order(struct adapter *padapter, struct recv_reor
>
> /* indicate this recv_frame */
> if (!pattrib->amsdu) {
> - if ((padapter->bDriverStopped == false) &&
> - (padapter->bSurpriseRemoved == false))
> + if ((!padapter->bDriverStopped) &&
> + (!padapter->bSurpriseRemoved))
> rtw_recv_indicatepkt(padapter, prframe);/* indicate this recv_frame */
I agree with Ethan that you should remove these parentheses.
regards,
dan carpenter
next prev parent reply other threads:[~2026-04-01 8:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 18:46 [PATCH v2 0/2] staging: rtl8723bs: cleanup code and style Andrei Khomenkov
2026-03-30 18:46 ` [PATCH v2 1/2] staging: rtl8723bs: simplify boolean comparisons Andrei Khomenkov
2026-03-31 22:13 ` Ethan Tidmore
2026-04-01 8:18 ` Dan Carpenter [this message]
2026-03-30 18:46 ` [PATCH v2 2/2] staging: rtl8723bs: cleanup code style and parentheses Andrei Khomenkov
2026-03-31 8:39 ` Greg Kroah-Hartman
2026-04-01 8:22 ` Dan Carpenter
2026-03-30 20:23 ` [PATCH v2 0/2] staging: rtl8723bs: cleanup code and style Luka Gejak
2026-03-31 11:06 ` Luka Gejak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aczUykCMQVYbk5Ej@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=khomenkov@mailbox.org \
--cc=linux-staging@lists.linux.dev \
--cc=luka.gejak@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox