Re: [PATCH v2 2/2] staging: rtl8723bs: cleanup code style and parentheses

[Dan Carpenter <error27@gmail.com>]

On Mon, Mar 30, 2026 at 09:46:39PM +0300, Andrei Khomenkov wrote:
> Cleanup the driver code to better match the kernel coding style.
> This patch includes:
>  - Removal of redundant parentheses in if-statements and expressions.
>  - Adding missing spaces around bitwise and logical operators.
>  - Reformatting multi-line conditions for better readability.
>  - Reformatting long conditions for better readability.
> 
> These changes are purely cosmetic and do not alter the driver logic.
> 
> Signed-off-by: Andrei Khomenkov <khomenkov@mailbox.org>
> ---
>  drivers/staging/rtl8723bs/core/rtw_btcoex.c   |  4 +--
>  .../staging/rtl8723bs/core/rtw_ieee80211.c    |  2 +-
>  .../staging/rtl8723bs/core/rtw_ioctl_set.c    |  8 ++---
>  drivers/staging/rtl8723bs/core/rtw_mlme.c     |  6 ++--
>  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c |  4 +--
>  drivers/staging/rtl8723bs/core/rtw_recv.c     | 34 +++++++++----------
>  .../staging/rtl8723bs/core/rtw_wlan_util.c    |  2 +-
>  drivers/staging/rtl8723bs/core/rtw_xmit.c     | 23 +++++++------
>  drivers/staging/rtl8723bs/hal/odm.c           |  2 +-
>  drivers/staging/rtl8723bs/hal/odm_DIG.c       | 16 ++++-----
>  .../staging/rtl8723bs/hal/rtl8723b_hal_init.c |  5 +--
>  drivers/staging/rtl8723bs/hal/sdio_halinit.c  |  6 ++--
>  .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c |  9 ++---
>  drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 11 +++---
>  14 files changed, 64 insertions(+), 68 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_btcoex.c b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
> index 9a7acabef409..f09510048b93 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_btcoex.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
> @@ -10,8 +10,8 @@
>  
>  void rtw_btcoex_MediaStatusNotify(struct adapter *padapter, u8 media_status)
>  {
> -	if ((media_status == RT_MEDIA_CONNECT)

These parentheses, on the other hand, you should leave because
Greg is fine or even prefers parentheses around "(foo == bar)".
So when you're converting "(foo == false) ||" to "!foo ||" then
drop the parentheses.  In that situation the parens were because
of the == and then when you remove the == you need to remove the
parens as well.  But here the == is in the final condition so keep
the parens.

> -		&& (check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE))) {
> +	if (media_status == RT_MEDIA_CONNECT &&
> +	    check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE)) {
>  		rtw_hal_set_hwreg(padapter, HW_VAR_DL_RSVD_PAGE, NULL);
>  	}
>  

regards,
dan carpenter