From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
gregkh@linuxfoundation.org, dlechner@baylibre.com,
nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: frequency: ad9834: clean up includes
Date: Wed, 15 Apr 2026 17:37:28 +0300 [thread overview]
Message-ID: <ad-iqJxCoZ18nESz@ashevche-desk.local> (raw)
In-Reply-To: <20260415112030.1324-1-joshua.crofts1@gmail.com>
On Wed, Apr 15, 2026 at 11:20:30AM +0000, Joshua Crofts wrote:
> Cleanup include headers by removing proxy kernel.h
> header and unnecessary list.h, interrupt.h, workqueue.h
> and slab.h headers. Reordered remaining drivers
s/drivers/headers/
> alphabetically.
>
> Verified using IWYU.
Probably you need to somehow elaborate that this is tool, IWYU is the acronym
of the principle, tool called 'iwyu'. Maybe adding a link?
"Verified with help of IWYU tool (...here is URL...).
> Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
...
> +#include <linux/bits.h>
> #include <linux/clk.h>
> -#include <linux/interrupt.h>
> -#include <linux/workqueue.h>
> #include <linux/device.h>
> -#include <linux/kernel.h>
> -#include <linux/slab.h>
> -#include <linux/sysfs.h>
> -#include <linux/list.h>
> -#include <linux/spi/spi.h>
> -#include <linux/regulator/consumer.h>
> #include <linux/err.h>
> #include <linux/module.h>
> +#include <linux/regulator/consumer.h>
> +#include <linux/spi/spi.h>
> +#include <linux/sysfs.h>
Still missing types.h, math.h, and probably more...
Yes, asm/byteorder.h, kstrtox.h, mutex.h. And maybe even more, I just
briefly scrolled over the driver code.
If you look at Git history of the replacement kernel.h in the drivers
you may find that usually it takes 10+ headers to be added.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-15 14:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 11:20 [PATCH v2] iio: frequency: ad9834: clean up includes Joshua Crofts
2026-04-15 14:37 ` Andy Shevchenko [this message]
2026-04-16 9:05 ` Joshua Crofts
2026-04-16 9:20 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad-iqJxCoZ18nESz@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox