Re: [PATCH v3 1/2] iio: frequency: ad9832: remove kernel.h proxy header.

Joshua Crofts
2026-04-14T13:27:43Z

On Tue, 14 Apr 2026 at 13:43, Andy Shevchenko
<andriy.shevchenko@intel.com> wrote:
> Please, avoid following the suggestions blindly. This work needs a careful
> check of what's exactly is being used and which header should provide the
> necessary information. While it may compile it might be still wrong. You
> need to (briefly) read the code in full. I don't use iwyu tool with tweaks
> by Jonathan Cameron, old school guy, but you can also try it [1].

Don't worry, I wasn't blindly following your suggestions. After some tweaking,
IWYU recommends keeping device.h and removing slab.h. My question is
whether the swap from asm/div64.h to linux/math64.h is valid? The asm
implementation would be platform specific, so swapping to math64 seems
like a good idea.

--
Kind regards

CJD