From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
gregkh@linuxfoundation.org, dlechner@baylibre.com,
nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] iio: frequency: ad9832: simplify bitwise math
Date: Tue, 14 Apr 2026 12:44:14 +0300 [thread overview]
Message-ID: <ad4MbnpAfBEXKDzm@ashevche-desk.local> (raw)
In-Reply-To: <20260411123512.84739-3-joshua.crofts1@gmail.com>
On Sat, Apr 11, 2026 at 02:35:12PM +0200, Joshua Crofts wrote:
> Refactor the ad9832_calc_freqreg by adding a BIT_ULL()
> macro instead of manual bit shifting for better
> readability.
"While at it, switch to u64 type for the local variable
that may hold big values."
...
> - unsigned long long freqreg = (u64)fout *
> - (u64)((u64)1L << AD9832_FREQ_BITS);
> + u64 freqreg = (u64)fout * BIT_ULL(AD9832_FREQ_BITS);
It can even be just like this:
u64 freqreg = fout * BIT_ULL(AD9832_FREQ_BITS);
if I understand the integer promotion for unsigned types here
and the * operator correctly.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-14 9:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-11 12:35 [PATCH v3 0/2] iio: frequency: ad9832: cleanups Joshua Crofts
2026-04-11 12:35 ` [PATCH v3 1/2] iio: frequency: ad9832: remove kernel.h proxy header Joshua Crofts
2026-04-14 9:38 ` Andy Shevchenko
2026-04-14 10:12 ` Joshua Crofts
2026-04-14 11:43 ` Andy Shevchenko
2026-04-14 13:27 ` Joshua Crofts
2026-04-14 17:03 ` Andy Shevchenko
2026-04-15 7:18 ` Joshua Crofts
2026-04-11 12:35 ` [PATCH v3 2/2] iio: frequency: ad9832: simplify bitwise math Joshua Crofts
2026-04-14 9:44 ` Andy Shevchenko [this message]
2026-04-14 9:51 ` Joshua Crofts
2026-04-14 9:57 ` Andy Shevchenko
2026-04-14 10:45 ` Joshua Crofts
2026-04-14 12:33 ` Andy Shevchenko
2026-04-14 13:02 ` Dan Carpenter
2026-04-14 16:59 ` Andy Shevchenko
2026-04-13 7:05 ` [PATCH v3 0/2] iio: frequency: ad9832: cleanups Joshua Crofts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad4MbnpAfBEXKDzm@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox